Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1145
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1145#issuecomment-142553329
This is more robust, because Akka has retry loop when trying to bind to the
randomly picked port, right? The change looks good and works fine. +1
Optional: I would
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1145#issuecomment-142554024
I think that the Akka will just randomly pick a free port. Thus, there is
no need for retrying.
I'll add the comments to the test. That's a good point :-)
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1145#issuecomment-142554920
Ah yeah they directly bind the socket :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1145#issuecomment-141923403
Failing test case is
`org.apache.flink.yarn.YARNSessionFIFOITCase.testJavaAPI` and, thus, unrelated.
---
If your project is set up for it, you can reply to this
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1145
[FLINK-2694] [test-stability] Hardens the
JobManagerProcessReapingTest.testReapProcessOnFailure test case
The `JobManagerProcessReapingTest.testReapProcessOnFailure` predetermines
the port
