Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-149200585
Thanks. Looks great. Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r42351565
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/web/WebFrontendITCase.java ---
@@ -110,21 +112,18 @@ public void getTaskmanagers() {
}
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-149160757
Looks good, @sachingoel0101. I think we can merge this if we adapt the test
which checks for the log file access in the web frontend.
---
If your project is set up for
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-149142260
Thanks a lot @sachingoel0101. I'll check out and test your changes now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-149171828
Hi @mxm I have fixed the `WebFrontendITCase`. Please have a look again.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-149036747
@mxm I've rebased on your latest changes to enable dashboard on yarn.
Also, there was a little redundant code in `StaticFileServerHandler`
```java
if
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-146433225
@rmetzger , I looked at your changes to enable the dashboard on yarn. Looks
good. :)
A few comments to make sure this PR can directly start working after
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-146473400
@uce Since the web frontend isn't integrated yet, I have verified correct
logs directory paths by examining container logs by deploying on yarn. This
will now
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-146752849
IMO this can be merged as it works as expected in non-yarn mode. And the
number of changes to be made are minimal when you finally merge your PR.
I can
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-146737214
@sachingoel0101: my pull request
(https://github.com/apache/flink/pull/1222) is actually based on @uce's PR
(https://github.com/apache/flink/pull/1202). I'm not sure
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-146319734
@uce, the new web dashboard doesn't work with yarn yet. The files are not
shipped with the jar. I'm confused why it isn't being done so. The old
frontend's files
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41393269
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -276,4 +294,18 @@ public int getServerPort() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41393573
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
@@ -123,9 +124,18 @@ public void
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41393603
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -276,4 +294,18 @@ public int getServerPort() {
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41395108
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -276,4 +294,18 @@ public int getServerPort() {
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-146208712
I made some comments. I've initially said that I am going to address them
myself, but I won't have the time today. Can you please address them? Thanks
for the fast PR btw.
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41397837
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
@@ -123,9 +124,18 @@ public void
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41398012
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
@@ -123,9 +124,18 @@ public void
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1233#issuecomment-146217143
@uce , @fhueske thanks for the review.
I've addressed all your concerns and am testing it right now.
However, I'm not at all familiar with yarn and
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41395253
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -139,7 +148,14 @@ else if (flinkRoot != null) {
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41395123
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -160,8 +176,10 @@ else if (flinkRoot != null) {
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41395372
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
@@ -177,7 +187,11 @@ public void
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41397816
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
@@ -177,7 +187,11 @@ public void
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41398182
--- Diff: flink-runtime-web/web-dashboard/app/styles/index.styl ---
@@ -405,3 +405,7 @@ pre.exception
.table
td.td-long
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41397986
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -139,7 +148,14 @@ else if (flinkRoot !=
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41395336
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
@@ -123,9 +124,18 @@ public void
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1233#discussion_r41395166
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -139,7 +148,14 @@ else if (flinkRoot != null) {
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1233
[FLINK-2731][web-dashboard] Adds access to Job Manager stdout and log.
This adds minimalist support for accessing Job manager logs and stdout
files to the new web frontend.
Right now, to
29 matches
Mail list logo
