Github user twalthr closed the pull request at:
https://github.com/apache/flink/pull/1679
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1679#issuecomment-188669681
Thanks for the update. Looks good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1679#issuecomment-188655499
If there are no objections, I would like to merge this later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1679#issuecomment-188219011
@fhueske build succeeded
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53910352
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/StringExpressionsITCase.java
---
@@ -40,46 +40,6 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53906027
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/StringExpressionsITCase.java
---
@@ -40,46 +40,6 @@ public
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53905333
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/test/ScalarFunctionsTest.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53905238
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/StringExpressionsITCase.java
---
@@ -40,46 +40,6 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53763449
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/StringExpressionsITCase.java
---
@@ -40,46 +40,6 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53763441
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/StringExpressionsITCase.scala
---
@@ -18,42 +18,20 @@
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1679#issuecomment-187648227
I had only a few minor comments. Looks mostly good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53763082
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/test/ScalarFunctionsTest.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53751120
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -702,12 +704,17 @@ class CodeGenerator(
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1679
[FLINK-3226] Translation of scalar function substring()
This PR implements the scalar function `substring()` for the Table API on
Calcite. Additionally, it already contains preparations for more
14 matches
Mail list logo
