[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-06-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65371629 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/CompactingHashTableTest.java --- @@ -252,4 +262,81 @@ private static String

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-06-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65371616 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTestCommon.java --- @@ -0,0 +1,666 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-06-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65371572 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/chaining/ChainedReduceCombineDriver.java --- @@ -0,0 +1,305 @@ +/* + *

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-06-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65356958 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-06-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65356908 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-06-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65356863 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-06-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65331149 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65233230 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231707 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231642 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231516 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java --- @@ -114,85 +118,133 @@ public void prepare() throws

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231501 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/chaining/ChainedReduceCombineDriver.java --- @@ -0,0 +1,305 @@ +/* + *

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231386 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java --- @@ -42,34 +44,38 @@ * Combine operator for Reduce

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65229499 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java --- @@ -42,34 +44,38 @@ * Combine operator for Reduce

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65228287 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala --- @@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag]( }

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65228213 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/UnsortedGrouping.java --- @@ -135,10 +136,37 @@ public UnsortedGrouping(DataSet set,

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65219886 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala --- @@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag]( }

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65216454 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java --- @@ -42,34 +44,38 @@ * Combine operator for Reduce