Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1979#issuecomment-218820979
No one should implement it. With interfaces it's hard to now what the
stance is, that's why I'm including those two. @rmetzger implemented the tool
that will check
Github user knaufk commented on the pull request:
https://github.com/apache/flink/pull/1979#issuecomment-218819781
I was worried about this to and intially only added the method to the
AbstractRuntimeUDFContext. On the other hand, are you aware of anyone who has
implemented
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1979#issuecomment-218817622
R: @rmetzger
R: @StephanEwen
What do you think about the interface. This adds a method to
`RuntimeContext`. This does not break if users are only using
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1979#issuecomment-218816900
Ok, thanks! I'm merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user knaufk commented on the pull request:
https://github.com/apache/flink/pull/1979#issuecomment-218815109
Hopefully, fixed the formatting stuff. If there are still missing lines or
so, please just go ahead and fix it during merging...
---
If your project is set up for it,
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1979#issuecomment-218805483
Nice and straightforward, I just had some minor comments about formatting.
ð
And of course we protect the feature with a test.
If you want I can
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1979#discussion_r63047675
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/Trigger.java
---
@@ -169,7 +170,17 @@ public void clear(W
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1979#discussion_r63047584
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/Trigger.java
---
@@ -169,7 +170,17 @@ public void clear(W
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1979#discussion_r63047546
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
---
@@ -133,13 +132,24 @@ public DoubleCounter
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1979#discussion_r63047435
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
---
@@ -43,9 +38,13 @@
import
Github user knaufk closed the pull request at:
https://github.com/apache/flink/pull/1979
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user knaufk reopened a pull request:
https://github.com/apache/flink/pull/1979
[FLINK-3758] Add possibility to register accumulators in custom triggers
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
GitHub user knaufk opened a pull request:
https://github.com/apache/flink/pull/1979
[Flink 3758] Add possibility to register accumulators in custom triggers
1 of 1
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
13 matches
Mail list logo
