Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-108290010
Thanks for your work. :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/695
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-107422496
Is this good to merge now? I'm rewriting all the sources (again) and this
should probably go in.
---
If your project is set up for it, you can reply to this email and
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-107551663
I think it is good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-105845451
I tried to merge this, but it is quite unmergeable.
Before we can add this, we need you to rebase this pull request and squash
all commits into one commit.
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-105884995
Done. I hope every thing works fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-104705751
It looks like many unrelated commits are part of the pull request. I
suspect something went wrong while merging/rebasing.
Can you take a look?
---
If your project
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-104243817
The problem was that the TwitterSource.next method was not implemented
properly. There were also dead code. I fixed it and now it is working.
---
If your project
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-104230142
TwitterSource does not work after the last update. Now, it sends null
messages. I try to fix it.
---
If your project is set up for it, you can reply to this email
Github user HilmiYildirim commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30677156
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSourceTest.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-103848061
+1 to merge like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30691440
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSourceTest.java
---
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30724769
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSourceTest.java
---
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-103963870
Add one more small request to add comments as JavaDoc for the test then it
should ready to go.
Thanks again for the contribution.
---
If your project is set up for
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30724526
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSourceTest.java
---
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-103498471
Thank you for working on the issue. I'll soon review your changes in detail.
From what I saw by scrolling over it, it looks very good (with log messages
and
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-103499923
It is possible to implement an integration test. For example, I can
track a term and then I has to check if all tweets contain the term. If
you want I can
Github user HilmiYildirim commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30621383
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSource.java
---
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30620688
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSourceTest.java
---
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30620574
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSource.java
---
Github user HilmiYildirim commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30622577
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSourceTest.java
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-103597087
Unfortunately, it is not possible ti implement this as Junit Tests. The
stream connection needs access keys of a twitter account and the maximum number
of parallel
GitHub user HilmiYildirim opened a pull request:
https://github.com/apache/flink/pull/695
Implemented TwitterSourceFilter and adapted TwitterSource
I implemented the class TwitterFilterSource which inherits from
TwitterSource. It enables to filter twitter streams, for example, by
Github user HilmiYildirim commented on a diff in the pull request:
https://github.com/apache/flink/pull/695#discussion_r30622734
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSourceTest.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-103579307
That would be really great, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
25 matches
Mail list logo
