Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1343#discussion_r44404877
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -167,15 +166,11 @@ public WindowedStream(K
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1343#issuecomment-155417298
+1 Changes look good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1343#discussion_r44404693
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -167,15 +166,11 @@ public WindowedStream(KeyedS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1343#discussion_r44404515
--- Diff: tools/maven/checkstyle.xml ---
@@ -54,11 +54,18 @@ under the License.
+
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1343#issuecomment-155412487
I tested the change on a cluster and it's working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1343#discussion_r44397599
--- Diff: tools/maven/checkstyle.xml ---
@@ -54,11 +54,18 @@ under the License.
+
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1343
Remove and forbid use of SerializationUtils. Fix FLINK-2992
The SerializationUtils are usually not using the right classloader, and
they have some security issues.
I'm using our checkstyle rule
