Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1574
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-179895516
Thanks, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-179434902
Thanks for the comments, updated the PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-179138377
Looks good to me, but @gumchum's comment is valid.
One more thing, I would call the method on the Scala DataStream `def
javaStream : JavaStream[T] = stream`.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-178823650
Thanks for the comments. @gumchum: Internally it is stored as a Java
`Iterator` and that is the reason why left it so, but it definitely make sense
to convert it to Sc
Github user gumchum commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-178783922
Looks good. It looks like collect is returning a Java iterator instead of a
Scala one. Is there a reason for this given that the code is for Scala users?
---
If your pr
Github user cmonty commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-178683549
The Scala interface looks good to me and gets rid of the need to call
`getJavaStream` directly.
Thanks!
---
If your project is set up for it, you can reply to t
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1574
Scala DataStream&DataStreamUtils accessors fix
The PR contains two orthogonal approaches of fixing the access to
`DataStreamUtils.collect` for a scala environment. One or both of the
approaches ca
