[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-19 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/2447 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77318844 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/DummyEnvironment.java.orig --- @@ -1,185 +0,0 @@ -/* --- End

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77317670 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotOwner.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apac

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77317356 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAllocationFuture.java --- @@ -20,73 +20,125 @@ import

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77314097 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ConnectionID.java --- @@ -41,7 +41,7 @@ private final int connec

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77313861 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotSharingGroupAssignment.java --- @@ -576,7 +560,7 @@ private void internalDis

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77311597 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/InstanceManager.java --- @@ -147,7 +148,7 @@ public boolean reportHeartBeat(Inst

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r7737 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/Instance.java --- @@ -84,22 +90,22 @@ * Constructs an instance reflectin

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77310730 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java --- @@ -104,16 +107,17 @@ public String

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77310357 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/PartialInputChannelDeploymentDescriptor.java --- @@ -44,15 +44,15 @@ p

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77310204 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java --- @@ -104,16 +107,17 @@ public String

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77309411 --- Diff: flink-mesos/src/main/scala/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManager.scala --- @@ -19,20 +19,19 @@ package org.apa

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-09-01 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77161750 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAllocationFuture.java --- @@ -20,73 +20,125 @@ import

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-08-31 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77101490 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAllocationFuture.java --- @@ -20,73 +20,125 @@ import or

[GitHub] flink pull request #2447: [FLINK-4490] [distributed coordination] Decouple t...

2016-08-31 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/2447 [FLINK-4490] [distributed coordination] Decouple the JobManage's slots from the 'Instance' To allow for a future dynamic slot allocation and release model, the slots should not depend on 'Insta