[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-29 Thread mbalassi
Github user mbalassi commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r90032424 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -581,6 +637,16 @@ object ALS { val

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-11 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87588061 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -675,7 +756,69 @@ object ALS {

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-11 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87587473 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -273,6 +308,14 @@ object ALS { val

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-10 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87422110 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -273,6 +308,14 @@ object ALS { val

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-10 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87421513 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -675,7 +756,69 @@ object ALS {

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-10 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87355415 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -675,7 +756,69 @@ object ALS {

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-10 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87354805 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -535,8 +581,17 @@ object ALS { itemOut:

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-10 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87353990 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -273,6 +308,14 @@ object ALS { val

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-10 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87353332 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -156,6 +171,26 @@ class ALS extends

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-09 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87202604 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -675,7 +756,69 @@ object ALS {

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-09 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87199446 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -273,6 +308,14 @@ object ALS { val

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-09 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87195483 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -156,6 +171,26 @@ class ALS extends Predictor[ALS] {

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-11-09 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r87201508 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -535,8 +581,17 @@ object ALS { itemOut:

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81159482 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/recommendation/ImplicitALSTest.scala --- @@ -0,0 +1,171 @@ +/* + * Licensed

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81159171 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -581,6 +637,16 @@ object ALS { val

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81115301 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/recommendation/ImplicitALSTest.scala --- @@ -0,0 +1,171 @@ +/* + *

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81115229 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/recommendation/ImplicitALSTest.scala --- @@ -0,0 +1,171 @@ +/* + *

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81114406 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -581,6 +637,16 @@ object ALS { val

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81112771 --- Diff: docs/dev/libs/ml/als.md --- @@ -99,6 +114,26 @@ The alternating least squares implementation can be controlled by the following

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81112526 --- Diff: docs/dev/libs/ml/als.md --- @@ -99,6 +114,26 @@ The alternating least squares implementation can be controlled by the following

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81112516 --- Diff: docs/dev/libs/ml/als.md --- @@ -49,6 +49,21 @@ By applying this step alternately to the matrices $U$ and $V$, we can iterativel The