Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/3298#discussion_r101008339
--- Diff: flink-dist/src/main/flink-bin/bin/stop-cluster.sh ---
@@ -25,14 +25,30 @@ bin=`cd "$bin"; pwd`
# Stop TaskManager instance(s) using pdsh
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/3298#discussion_r101008195
--- Diff: flink-dist/src/main/flink-bin/bin/stop-cluster.sh ---
@@ -25,14 +25,30 @@ bin=`cd "$bin"; pwd`
# Stop TaskManager instance(s) using pdsh
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3298#discussion_r100978413
--- Diff: flink-dist/src/main/flink-bin/bin/stop-cluster.sh ---
@@ -25,14 +25,30 @@ bin=`cd "$bin"; pwd`
# Stop TaskManager instance(s) using pdsh
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3298#discussion_r100978305
--- Diff: flink-dist/src/main/flink-bin/bin/stop-cluster.sh ---
@@ -25,14 +25,30 @@ bin=`cd "$bin"; pwd`
# Stop TaskManager instance(s) using pdsh
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/3298
[FLINK-5672] add special cases for a local setup in cluster start/stop
scripts
With this PR, if all slaves refer to `"localhost"` we run the daemons from
the script itself instead of using ssh which
