[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878983 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnCLI.java --- @@ -85,6 +89,10 @@ public FlinkYarnCLI(String shortPrefix, String

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878445 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878609 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -131,6 +134,8 @@ /** Lazily initialized list

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878642 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -248,6 +253,14 @@ public void addShipFiles(List

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878685 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878413 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878546 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878668 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878523 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878488 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878472 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878375 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878350 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878339 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-03-02 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103878313 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196163 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196433 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103197159 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -136,21 +137,36 @@ public static Path setupLocalResource(

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103195082 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103178916 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r102957246 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103195228 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196509 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196883 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -136,21 +137,36 @@ public static Path setupLocalResource(

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103197726 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -131,6 +134,8 @@ /** Lazily initialized

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103195968 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103200589 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnCLI.java --- @@ -85,6 +89,10 @@ public FlinkYarnCLI(String shortPrefix, String

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103177388 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103194179 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103177980 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196755 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103181903 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103177702 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103194600 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -248,6 +253,14 @@ public void addShipFiles(List

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103194453 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103197098 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -136,21 +137,36 @@ public static Path setupLocalResource(

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196289 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103177052 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-22 Thread wenlong88
GitHub user wenlong88 opened a pull request: https://github.com/apache/flink/pull/3388 [FLINK-5815] Add resource files configuration for Yarn Mode This PR add three common resource configuration options to yarn mode, which allow user to set single file resource from both local