Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3409
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107722255
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +252,35 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107724116
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join(
}
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107636567
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join(
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107636115
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107347170
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107005694
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107009220
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107009611
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/StreamTableEnvironment.scala
---
@@ -180,4 +180,31 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107103482
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join(
}
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107061507
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join(
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107060990
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -165,3 +165,31 @@ case class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107059962
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106920718
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -165,3 +165,31 @@ case class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106921688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join(
}
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106921052
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106921358
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/StreamTableEnvironment.scala
---
@@ -180,4 +180,31 @@ class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r10636
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -353,19 +388,48 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368629
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368614
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368344
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -99,6 +101,9 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106025824
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -99,6 +101,9 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106104033
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -353,19 +388,48 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106025992
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106024978
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106026297
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -353,19 +388,48 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106026738
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join(
}
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106107064
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/ExternalCatalogITCase.scala
---
@@ -0,0 +1,85 @@
+/*
+
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3409
[flink-5570] [Table API & SQL]Support register external catalog to table
environment
This pr aims to support register external catalog to TableEnvironment.
The pr contains two commits, the
29 matches
Mail list logo
