Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r108790880
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -162,11 +182,65 @@ public
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r105826378
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -162,11 +182,65 @@ public
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r105825035
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -259,9 +262,11 @@ public String
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104838231
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +264,61 @@ public String
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104838693
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +264,61 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104795283
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104795107
--- Diff:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorkerTest.java
---
@@ -0,0 +1,75 @@
+/*
+ *
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104794320
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104793521
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104790634
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104790136
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104781670
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104779998
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -115,6 +122,11 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104780760
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104779885
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104780871
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104780664
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104780260
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104752423
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -131,9 +134,7 @@ public int
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104736408
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +263,71 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104736962
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +263,71 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104734849
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -131,9 +134,7 @@ public int getPorts()
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104735256
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +263,71 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104735340
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -115,6 +122,12 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104735237
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +263,71 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104735059
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +263,71 @@ public String
GitHub user addisonj opened a pull request:
https://github.com/apache/flink/pull/3481
[FLINK-5975] Add volume support to flink-mesos
When using containerization, specifically, docker, it is useful to be
able to attach additional volumes, such as an NFS share.
This adds
28 matches
Mail list logo