Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126645324
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -174,9 +210,38 @@ public void testUnrequestedByte() {
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126634784
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -174,9 +210,38 @@ public void testUnrequestedByte() {
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126452583
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -278,6 +518,26 @@ public void testUnrequestedRequired() {
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126450338
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -174,9 +210,38 @@ public void testUnrequestedByte() {
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126413856
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -174,9 +210,38 @@ public void testUnrequestedByte() {
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126413188
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -278,6 +518,26 @@ public void testUnrequestedRequired() {
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126412849
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -187,35 +252,122 @@ public void testUnrequestedShort() {
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126401183
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -34,8 +36,7 @@
@Test(expected = RuntimeExceptio
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126318967
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -34,8 +36,7 @@
@Test(expected = RuntimeExce
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126319040
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsPars
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126318935
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -548,6 +565,7 @@ protected Object clone() throws
CloneNotSupp
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126374745
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsPars
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125912602
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911520
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911372
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125910799
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -34,8 +36,7 @@
@Test(expected = RuntimeExceptio
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911839
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911637
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125910930
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -78,18 +79,12 @@ public void testMultipleNoValMixed() {
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911852
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125912201
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911760
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911804
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911011
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -78,18 +79,12 @@ public void testMultipleNoValMixed() {
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911613
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125914354
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911549
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser()
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125910462
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -548,6 +565,7 @@ protected Object clone() throws
CloneNotSupporte
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4169
[FLINK-6357] [java] ParameterTool get unrequested parameters
Adds ParameterTool#getUnrequestedParameters returning a Set of
parameter arguments names not yet requested by ParameterTool#has or any
30 matches
Mail list logo