[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4536 ---

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-09-26 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r140986388 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala --- @@ -36,10 +36,8 @@ import

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-09-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r140276174 --- Diff: docs/dev/table/udfs.md --- @@ -297,7 +297,7 @@ optionally implemented. While some of these methods allow the system more effici - `merge()`

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-09-21 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r140163581 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -40,17 +40,14 @@ class

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-09-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r137221865 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -40,17 +40,14 @@ class

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-31 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r136287683 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -74,48 +75,102 @@ class

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-30 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r136217663 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala --- @@ -36,10 +36,8 @@ import

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135430307 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala --- @@ -71,6 +69,9 @@ class

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135430161 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala --- @@ -36,10 +36,8 @@ import

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135425816 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -74,48 +75,102 @@ class

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135425060 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -350,8 +350,8 @@ abstract class

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135425261 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -18,39 +18,40 @@

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135425326 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -18,39 +18,40 @@

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135425277 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -18,39 +18,40 @@

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135426183 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala --- @@ -71,6 +69,9 @@ class

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135426134 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala --- @@ -36,10 +36,8 @@ import

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r135426250 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedTableFunctions.java --- @@ -35,4 +35,15 @@

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-14 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/4536 [FLINK-7439] [table] Support variable arguments for UDTF in SQL ## What is the purpose of the change Support variable arguments for UDTF in SQL ## Brief change log -