Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4559
---
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157709904
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -52,6 +54,10 @@
/** Flag
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157707628
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
---
@@ -99,6 +82,23 @@ protected Throwable
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157706995
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -52,6 +54,10 @@
/** Flag
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157706951
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
---
@@ -99,6 +82,23 @@ protected Throwable
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157703075
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
---
@@ -99,6 +82,23 @@ protected Throwable
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157694294
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -47,7 +48,14 @@ public void
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157693477
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -181,10 +182,27 @@ public void
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157691096
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -52,6 +54,10 @@
/** Flag
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157686388
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
---
@@ -99,6 +82,23 @@ protected Throwable
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157544965
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -161,6 +172,29 @@ public boolean
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157548033
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -52,6 +54,10 @@
/** Flag
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157540910
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -47,7 +48,14 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157539147
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -239,6 +261,10 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157538061
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionTest.java
---
@@ -103,16 +104,35 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157548895
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
@@ -77,6 +78,10 @@
/** Flag
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157541024
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -62,7 +70,14 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157545208
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
@@ -237,6 +243,29 @@ public boolean
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157538818
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -181,10 +182,27 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157544794
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
---
@@ -99,6 +82,23 @@ protected Throwable
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r155458048
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -145,6 +145,10 @@ public Buffer
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r155454935
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
---
@@ -22,32 +22,57 @@
import
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r155454886
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java
---
@@ -39,13 +39,15 @@
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154343510
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java
---
@@ -39,13 +39,15 @@
private
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154344889
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -133,7 +135,7 @@ int
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154344924
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java
---
@@ -114,7 +116,7 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154344942
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java
---
@@ -174,19 +175,21 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154343587
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
---
@@ -22,32 +22,57 @@
import
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154343656
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
---
@@ -22,32 +22,57 @@
import
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564080
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java
---
@@ -114,7 +116,7 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564859
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
---
@@ -22,32 +22,52 @@
import
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153563915
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java
---
@@ -39,13 +39,15 @@
private
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564111
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java
---
@@ -174,19 +175,21 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564062
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -133,7 +135,7 @@ int
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r152193809
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -145,6 +145,10 @@ public Buffer
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r152008483
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
@@ -246,9 +246,9 @@ public int
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r152008221
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -145,6 +145,10 @@ public Buffer
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r152008524
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
@@ -246,9 +246,9 @@ public int
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r152010406
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
---
@@ -41,12 +41,19 @@
/** The total
39 matches
Mail list logo
