[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4764 ---

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r145341988 --- Diff: flink-core/src/test/java/org/apache/flink/util/ResourceGuardTest.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r145341403 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java --- @@ -66,14 +66,13 @@ import org.apache.flink.r

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r145341323 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java --- @@ -215,46

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r145341268 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -618,1

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r143685852 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r143686389 --- Diff: flink-core/src/test/java/org/apache/flink/util/ResourceGuardTest.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r143685630 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java --- @@ -215,46 +215,

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r143686824 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java --- @@ -66,14 +66,13 @@ import org.apache.flink.runtime

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r143685204 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -618,19 +600

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r143681902 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java --- @@ -33,6 +3

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142592523 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142588647 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142579521 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -356,28 +35

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142493960 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142492040 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142490404 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/4764 [FLINK-7757] [checkpointing] Introduce resource guard for RocksDBKeye… …dStateBackend to reduce locking and avoid blocking behavior. ## What is the purpose of the change