[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5065 ---

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user Aegeaner commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r155746723 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -721,6 +722,42 @@ abstract class TableEnviron

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user Aegeaner commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r155746766 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -721,6 +722,42 @@ abstract class TableEnviron

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user Aegeaner commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r155741290 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -721,6 +722,42 @@ abstract class TableEnviron

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user Aegeaner commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r155741244 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -411,6 +411,7 @@ abstract class TableEnvironm

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user Aegeaner commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r155740555 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -98,7 +98,9 @@ abstract class BatchTable

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r154965051 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -721,6 +722,42 @@ abstract class TableEnvironm

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r154964510 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -721,6 +722,42 @@ abstract class TableEnvironm

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r154961218 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -98,7 +98,9 @@ abstract class BatchTableE

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r154967459 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -411,6 +411,7 @@ abstract class TableEnvironme

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5065#discussion_r154968022 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -721,6 +722,42 @@ abstract class TableEnvironm

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

GitHub user Aegeaner opened a pull request: https://github.com/apache/flink/pull/5065 [FLINK-8139][table] Check for proper equals() and hashCode() when reg… https://issues.apache.org/jira/browse/FLINK-8139 Check for proper equals() and hashCode() when registering a table.