Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5099
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r156386303
--- Diff: docs/monitoring/metrics.md ---
@@ -333,7 +333,7 @@ reporters will be instantiated on each job and task
manager when they are starte
-
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r156052191
--- Diff: docs/monitoring/metrics.md ---
@@ -329,11 +329,11 @@ or by assigning unique names to jobs and operators.
Metrics can be exposed to an external
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r156051769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -44,7 +48,13 @@
private static
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r155625966
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/MetricRegistryImplTest.java
---
@@ -76,8 +76,27 @@ public void testIsShutdown() {
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r155620220
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -108,15 +118,36 @@ public static
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r155618187
--- Diff: docs/monitoring/metrics.md ---
@@ -329,11 +329,11 @@ or by assigning unique names to jobs and operators.
Metrics can be exposed to an
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r155623170
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -44,7 +48,13 @@
private static
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154598676
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -43,8 +46,8 @@
private static
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154315071
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java ---
@@ -25,20 +25,9 @@
public class MetricOptions {
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154121821
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -43,8 +46,8 @@
private
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154122694
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java ---
@@ -25,20 +25,9 @@
public class MetricOptions {
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5099
[FLINK-8080][metrics] Remove need for "metrics.reporters" config key
## What is the purpose of the change
This PR simplifies the reporter configuration by no longer requiring users
to
13 matches
Mail list logo
