[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-31 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r165244013 --- Diff: flink-dist/src/main/flink-bin/conf/logback-yarn.xml --- @@ -17,8 +17,14 @@ --> - + ${log.file}

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-31 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r165244025 --- Diff: flink-dist/src/main/flink-bin/conf/logback.xml --- @@ -17,8 +17,14 @@ --> - + ${log.file}

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-31 Thread XuMingmin
Github user XuMingmin commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r165141492 --- Diff: flink-dist/src/main/flink-bin/conf/logback.xml --- @@ -17,8 +17,14 @@ --> - + ${log.file} +

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-31 Thread XuMingmin
Github user XuMingmin commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r165141378 --- Diff: flink-dist/src/main/flink-bin/conf/logback-yarn.xml --- @@ -17,8 +17,14 @@ --> - + ${log.file}

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-30 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r164940131 --- Diff: flink-dist/src/main/flink-bin/conf/logback-yarn.xml --- @@ -17,7 +17,7 @@ --> - + --- End diff --

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-30 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r164940108 --- Diff: flink-dist/src/main/flink-bin/conf/log4j.properties --- @@ -31,10 +31,11 @@ log4j.logger.org.apache.hadoop=INFO

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-30 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r164940066 --- Diff: flink-dist/src/main/flink-bin/conf/log4j-cli.properties --- @@ -19,10 +19,11 @@ log4j.rootLogger=INFO, file # Log all infos in

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-30 Thread XuMingmin
Github user XuMingmin commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r164895415 --- Diff: flink-dist/src/main/flink-bin/conf/log4j-cli.properties --- @@ -19,10 +19,11 @@ log4j.rootLogger=INFO, file # Log all infos in

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-30 Thread XuMingmin
Github user XuMingmin commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r164895503 --- Diff: flink-dist/src/main/flink-bin/conf/log4j.properties --- @@ -31,10 +31,11 @@ log4j.logger.org.apache.hadoop=INFO

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-30 Thread XuMingmin
Github user XuMingmin commented on a diff in the pull request: https://github.com/apache/flink/pull/5371#discussion_r164895963 --- Diff: flink-dist/src/main/flink-bin/conf/logback-yarn.xml --- @@ -17,7 +17,7 @@ --> - + --- End diff --

[GitHub] flink pull request #5371: [FLINK-8357] [conf] Enable rolling in default log ...

2018-01-26 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/5371 [FLINK-8357] [conf] Enable rolling in default log settings ## What is the purpose of the change *Enable rolling in default log settings.* ## Brief change log -