[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5500 ---

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171252476 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java --- @@ -163,12 +163,16 @@ public

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253833 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -847,12 +834,12 @@ public long extractTimestamp(String

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171252617 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java --- @@ -118,7 +118,7 @@ *

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253126 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperatorTest.java --- @@ -220,7 +227,8 @@ public

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253604 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -740,24 +734,17 @@ public void testProcessTranslation()

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253628 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -740,24 +734,17 @@ public void testProcessTranslation()

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253550 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -701,19 +701,13 @@ public void

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253575 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -701,19 +701,13 @@ public void

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171252831 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java --- @@ -288,7 +288,7 @@ public long

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171252385 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java --- @@ -163,12 +163,16 @@ public

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253705 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -801,12 +788,12 @@ public long extractTimestamp(String

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253807 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -847,12 +834,12 @@ public long extractTimestamp(String

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253672 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -801,12 +788,12 @@ public long extractTimestamp(String

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253650 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -740,24 +734,17 @@ public void testProcessTranslation()

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r171253275 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperatorTest.java --- @@ -381,26 +392,28 @@

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r169057826 --- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BroadcastStateITCase.java --- @@ -169,7 +170,10 @@ public void

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r169051920 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperatorTest.java --- @@ -204,6 +208,8 @@

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r169055105 --- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BroadcastStateITCase.java --- @@ -145,17 +147,16 @@ public Watermark

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r169051991 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperatorTest.java --- @@ -358,6 +365,8 @@

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r169055575 --- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BroadcastStateITCase.java --- @@ -145,17 +147,16 @@ public Watermark

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r169058054 --- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BroadcastStateITCase.java --- @@ -145,17 +147,16 @@ public Watermark

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r169054889 --- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BroadcastStateITCase.java --- @@ -145,17 +147,16 @@ public Watermark

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r169057332 --- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BroadcastStateITCase.java --- @@ -169,7 +170,10 @@ public void

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r168855562 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java --- @@ -324,6 +324,11 @@

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r168697719 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java --- @@ -324,6 +324,11 @@

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5500 [FLINK-8667] expose key in KeyedBroadcastProcessFunction#onTimer() ## What is the purpose of the change Expose key in `KeyedBroadcastProcessFunction#onTimer(OnTimerContext)`.