Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5734
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5734#discussion_r176029020
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -292,6 +292,13 @@ public void start() throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5734#discussion_r176028213
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -265,7 +265,11 @@ class TaskManager(
case t:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5734#discussion_r176028191
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -292,6 +292,13 @@ public void start() throws Exception
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5734
[FLINK-9026][Metrics] Close the TaskManagerMetricGroup when the
TaskExecutor is shut down
## What is the purpose of the change
We should close the `TaskManagerMetricGroup` when the
