[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6062 ---

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-30 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191772629 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-30 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191768328 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-30 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191738639 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-30 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191732576 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java --- @@ -0,0 +1,470 @@ +/* +

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-30 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191732272 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimersSnapshotReaderWriters.java --- @@ -96,7 +96,7 @@

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-30 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191731222 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,246 @@ +/*

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-30 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191730978 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,246 @@ +/*

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-30 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191711210 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -199,17 +186,9 @@ public

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191454466 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191414669 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191446484 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java --- @@ -0,0 +1,470 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191445752 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimersSnapshotReaderWriters.java --- @@ -96,7 +96,7 @@

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191440142 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,246 @@ +/* +

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191422654 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191450664 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java --- @@ -0,0 +1,470 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191413234 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -301,114 +259,39 @@ public

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191447784 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java --- @@ -0,0 +1,470 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191425505 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191426419 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191436243 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,246 @@ +/* +

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191419645 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191435370 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191432905 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191446801 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java --- @@ -0,0 +1,470 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191427611 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191423366 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,511 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191440434 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,246 @@ +/* +

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191441546 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,246 @@ +/* +

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191447618 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java --- @@ -0,0 +1,470 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191440239 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,246 @@ +/* +

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191409829 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -96,14 +91,12 @@

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191446041 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java --- @@ -0,0 +1,470 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r191412983 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -199,17 +186,9 @@ public

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-24 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190517094 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -458,24 +458,33 @@ private int

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-24 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190517336 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java --- @@ -23,8 +23,8 @@ /** * Internal

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190482258 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190481987 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,235 @@ +/*

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190463723 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,235 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190311650 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190296235 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190295347 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190294307 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190293752 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190293256 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190290965 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190289953 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190288320 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190285625 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java --- @@ -0,0 +1,235 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6062#discussion_r190279440 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -0,0 +1,504 @@ +/* + *

[GitHub] flink pull request #6062: [FLINK-9423][state] Implement efficient deletes fo...

2018-05-23 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/6062 [FLINK-9423][state] Implement efficient deletes for heap-based timer … …service. ## What is the purpose of the change This PR introduces `InternalTimerHeap`, as data