[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6120 ---

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-18 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203605524 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -545,15 +543,15 @@ public IntervalJoined(

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-17 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203083498 --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java --- @@ -271,19 +214,20 @@ public void

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203060212 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java --- @@ -102,15 +104,62 @@ public void

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-17 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203040441 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java --- @@ -102,15 +104,62 @@ public void

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-17 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203021961 --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java --- @@ -50,12 +41,12 @@ import static

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203002928 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java --- @@ -102,15 +104,62 @@ public void

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203001399 --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java --- @@ -271,19 +214,20 @@ public void

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203003680 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -237,19 +248,81 @@ private boolean

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203001023 --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java --- @@ -50,12 +41,12 @@ import static

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r202553410 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -584,21 +581,6 @@ private static void registerFactory(Type

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r202552984 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -584,21 +581,6 @@ private static void registerFactory(Type

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-11 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r201662934 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -119,19 +120,15 @@ public boolean filter(Event value) throws

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-11 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r201655890 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -584,21 +581,6 @@ private static void

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-11 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r201657797 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -695,29 +678,14 @@ private static void

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-11 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r201655466 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -584,21 +581,6 @@ private static void

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-06-05 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/6120 [FLINK-7251] [types] Remove the flink-java8 module and improve lambda type extraction ## What is the purpose of the change This PR merge the `flink-java8` module into