[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201019320 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java --- @@ -37,10 +62,22 @@ /**

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201019266 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java --- @@ -37,10 +62,22 @@ /**

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201015311 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TestPriorityQueueSetFactory.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201016908 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201017209 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201015258 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TestPriorityQueueSetFactory.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201013962 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityQueueSetFactory.java --- @@ -0,0 +1,45 @@ +/* + * Licensed to the

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201016373 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201016655 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201014333 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -102,6 +105,21 @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201017540 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201016952 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6276 ---

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201013659 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupedInternalPriorityQueue.java --- @@ -0,0 +1,31 @@ +/* + *

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201011077 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupedInternalPriorityQueue.java --- @@ -0,0 +1,31 @@ +/* + *

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201010986 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupedInternalPriorityQueue.java --- @@ -0,0 +1,31 @@ +/* + *

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-06 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/6276 [FLINK-9486] Introduce TimerState in keyed state backend ## What is the purpose of the change This PR integrates `InternalTimerQueue` with keyed state backends (Heap and RocksDB),