[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6376 ---

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203982061 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java --- @@ -0,0 +1,155 @@ +/* + * Licensed to

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203981882 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/ValidatingSink.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203978845 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/WindowCheckpointingITCase.java --- @@ -92,19 +89,21 @@ private static

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203978691 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java --- @@ -0,0 +1,155 @@ +/* + * Licensed to

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203978368 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java --- @@ -88,20 +80,17 @@ public

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203978136 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java --- @@ -133,9 +122,12 @@ public

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203978068 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java --- @@ -299,12 +288,17 @@ public

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203976558 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java --- @@ -88,20 +80,17 @@ public void

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203976258 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java --- @@ -133,9 +122,12 @@ public void

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203974103 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/WindowCheckpointingITCase.java --- @@ -92,19 +89,21 @@ private static

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203973382 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/ValidatingSink.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203973756 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java --- @@ -0,0 +1,155 @@ +/* + * Licensed to the

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203973793 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java --- @@ -0,0 +1,155 @@ +/* + * Licensed to the

[GitHub] flink pull request #6376: [FLINK-9902][tests] Improve and refactor window ch...

2018-07-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6376#discussion_r203975395 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java --- @@ -299,12 +288,17 @@ public void