lincoln-lil commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1763405879
> @lincoln-lil Based on the approach you provided, I attempted to write some
test cases. However, there are two types that are not covered:
>
> 1. non comparable types: I don't
lincoln-lil commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1359886599
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
fengjiajie commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1359458406
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1762985221
@lincoln-lil Based on the approach you provided, I attempted to write some
test cases. However, there are two types that are not covered:
1. non comparable types: I don't know
fengjiajie commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1359102193
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
fengjiajie commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1359102193
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
lincoln-lil commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1358298316
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
libenchao commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1358160544
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
lincoln-lil commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1357746002
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1759267500
@lincoln-lil
Hi, I changed back to the previous approach. Please see if this is workable:
Keep the 'if' statement to indicate the case of handling TimePoint and
TimeString, and
fengjiajie commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1356549020
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
lincoln-lil commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1759102773
> @lincoln-lil Thank you for your review. Are the 5 datatypes you mentioned
referring to DATE, TIME_WITHOUT_TIME_ZONE, TIMESTAMP_WITHOUT_TIME_ZONE,
TIMESTAMP_WITH_TIME_ZONE, and
lincoln-lil commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1355984417
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/utils/ScalarOperatorsTestBase.scala:
##
@@ -51,6 +53,7 @@ abstract
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1759036712
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1757572608
@lincoln-lil
Thank you for your review. Are the 5 datatypes you mentioned referring to
DATE, TIME_WITHOUT_TIME_ZONE, TIMESTAMP_WITHOUT_TIME_ZONE,
TIMESTAMP_WITH_TIME_ZONE, and
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1757571050
@LadyForest Thank you for your review, and I have seen the discussion on
Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1757568842
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lincoln-lil commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1353989534
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -488,6 +488,18 @@ object
18 matches
Mail list logo
