1996fanrui commented on PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2141086375
> Maybe we should revert this commit and re-commit it in the next second or
third version
Sounds make sense to me. The JdbcSource is introduced in the current
versio
RocMarshal commented on PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2139538600
Hi, @1996fanrui .
Kafka introduced KafkaSource API in the Flink 1.12 branch
https://issues.apache.org/jira/browse/FLINK-18323
Afterwards, in Flink version 1.14, Kafk
1996fanrui merged PR #117:
URL: https://github.com/apache/flink-connector-jdbc/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
RocMarshal commented on code in PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593792023
##
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java:
##
@@ -144,7 +146,8 @@ void testJdbcReadPro
eskabetxe commented on code in PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593526480
##
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java:
##
@@ -144,7 +146,8 @@ void testJdbcReadProp
RocMarshal commented on code in PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593374629
##
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java:
##
@@ -144,7 +146,8 @@ void testJdbcReadPro
RocMarshal commented on code in PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593372606
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java:
##
@@ -179,13 +205,34 @@ public ScanRuntimeProvi
eskabetxe commented on code in PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1592285942
##
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java:
##
@@ -144,7 +146,8 @@ void testJdbcReadProp
RocMarshal closed pull request #117: [FLINK-33463][Connector/JDBC] Support the
implementation of dynamic source tables based on the new source
URL: https://github.com/apache/flink-connector-jdbc/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, p
RocMarshal commented on PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2077036231
HI, @eskabetxe @caicancai Could you help have a review if you had the free
time ? thx a lot.
--
This is an automated message from the Apache Git Service.
To respond to t
RocMarshal commented on PR #117:
URL:
https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2074135667
blocked by https://github.com/apache/flink-connector-jdbc/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
RocMarshal closed pull request #117: [FLINK-33463][Connector/JDBC] Support the
implementation of dynamic source tables based on the new source
URL: https://github.com/apache/flink-connector-jdbc/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, p
RocMarshal opened a new pull request, #117:
URL: https://github.com/apache/flink-connector-jdbc/pull/117
- Support the implementation of dynamic source tables based on the new source
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
13 matches
Mail list logo