Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
1996fanrui commented on PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2141086375 > Maybe we should revert this commit and re-commit it in the next second or third version Sounds make sense to me. The JdbcSource is introduced in the current versio

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
RocMarshal commented on PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2139538600 Hi, @1996fanrui . Kafka introduced KafkaSource API in the Flink 1.12 branch https://issues.apache.org/jira/browse/FLINK-18323 Afterwards, in Flink version 1.14, Kafk

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-08 Thread via GitHub
1996fanrui merged PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-08 Thread via GitHub
RocMarshal commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593792023 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java: ## @@ -144,7 +146,8 @@ void testJdbcReadPro

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-08 Thread via GitHub
eskabetxe commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593526480 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java: ## @@ -144,7 +146,8 @@ void testJdbcReadProp

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-07 Thread via GitHub
RocMarshal commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593374629 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java: ## @@ -144,7 +146,8 @@ void testJdbcReadPro

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-07 Thread via GitHub
RocMarshal commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593372606 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -179,13 +205,34 @@ public ScanRuntimeProvi

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-07 Thread via GitHub
eskabetxe commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1592285942 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java: ## @@ -144,7 +146,8 @@ void testJdbcReadProp

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-04-25 Thread via GitHub
RocMarshal closed pull request #117: [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source URL: https://github.com/apache/flink-connector-jdbc/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-04-25 Thread via GitHub
RocMarshal commented on PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2077036231 HI, @eskabetxe @caicancai Could you help have a review if you had the free time ? thx a lot. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-04-23 Thread via GitHub
RocMarshal commented on PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2074135667 blocked by https://github.com/apache/flink-connector-jdbc/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-04-20 Thread via GitHub
RocMarshal closed pull request #117: [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source URL: https://github.com/apache/flink-connector-jdbc/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-04-19 Thread via GitHub
RocMarshal opened a new pull request, #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117 - Support the implementation of dynamic source tables based on the new source -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi