Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-20 Thread via GitHub
gyfora merged PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
1996fanrui commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1495183092 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetric.java: ## @@ -39,12 +39,6 @@ public enum ScalingMetric { /**

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1494884380 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetric.java: ## @@ -39,12 +39,6 @@ public enum ScalingMetric { /** Cur

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1494880354 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetric.java: ## @@ -39,12 +39,6 @@ public enum ScalingMetric { /** Cur

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
gyfora commented on PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#issuecomment-1952573994 Makes sense, I will remove that commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
mxm commented on PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#issuecomment-1952564474 @gyfora Every breaking change in `ScalingMetrics` will cause the metric history to get dropped, e.g. renaming or change of enum order. That is ok if the window resets correct

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
gyfora commented on PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#issuecomment-1952541506 @mxm @1996fanrui while polishing / testing the PR I noticed that the removed metrics cause a backward incompatible change. I added a fix to allow such changes to go throug

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
1996fanrui commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1494239310 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetric.java: ## @@ -39,12 +39,6 @@ public enum ScalingMetric { /**

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-18 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1493771207 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -379,22 +484,75 @@ public static double getAverage(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-18 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1493771147 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -223,128 +203,65 @@ public static void computeLagMetric

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1490305805 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -171,7 +171,7 @@ private void runScalingLogic(Context ct

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1490305805 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -171,7 +171,7 @@ private void runScalingLogic(Context ct

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489408092 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -43,49 +44,61 @@ public static void computeLoadMetrics(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489403136 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/JobTopology.java: ## @@ -146,13 +145,18 @@ public static JobTopology fromJsonPlan

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489401020 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -356,13 +421,13 @@ public static double getAverage(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489399611 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -264,16 +299,14 @@ private void computeTargetDataRate(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489399318 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -341,6 +375,37 @@ public static double getAverage(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
gyfora commented on PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#issuecomment-194188 There are still some issues while actually running this so I need to track down some problems and add some new tests. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
mxm commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1488088408 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -264,16 +299,14 @@ private void computeTargetDataRate(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
gyfora commented on PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#issuecomment-1941448169 cc @mateczagany -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
gyfora opened a new pull request, #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774 ## What is the purpose of the change This PR aims to cover both [FLINK-34213](https://issues.apache.org/jira/browse/FLINK-34213) and [FLINK-34266](https://issues.apache.org/jira/