LadyForest merged PR #24271:
URL: https://github.com/apache/flink/pull/24271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
swuferhong commented on code in PR #24271:
URL: https://github.com/apache/flink/pull/24271#discussion_r1501959629
##
docs/setup_docs.sh:
##
@@ -36,24 +36,33 @@ function integrate_connector_docs {
}
+SKIP_INTEGRATE_CONNECTOR_DOCS=false
+for arg in "$@"; do
+ if [ "$arg" ==
swuferhong commented on code in PR #24271:
URL: https://github.com/apache/flink/pull/24271#discussion_r1501952578
##
docs/README.md:
##
@@ -37,6 +37,14 @@ Then build the docs from source:
$ ./build_docs.sh
```
+The shell `./build_docs.sh` will integrate external connector
LadyForest commented on code in PR #24271:
URL: https://github.com/apache/flink/pull/24271#discussion_r1501360520
##
docs/setup_docs.sh:
##
@@ -36,24 +36,33 @@ function integrate_connector_docs {
}
+SKIP_INTEGRATE_CONNECTOR_DOCS=false
+for arg in "$@"; do
+ if [ "$arg" ==
swuferhong commented on PR #24271:
URL: https://github.com/apache/flink/pull/24271#issuecomment-1956296250
Hi, @MartijnVisser. Could you please help review it again? Thank you so much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
swuferhong commented on code in PR #24271:
URL: https://github.com/apache/flink/pull/24271#discussion_r1493723623
##
docs/setup_docs.sh:
##
@@ -36,24 +36,34 @@ function integrate_connector_docs {
}
+SKIP_INTEGRATE_CONNECTOR_DOCS=false
+for arg in "$@"; do
+ if [ "$arg" ==
MartijnVisser commented on code in PR #24271:
URL: https://github.com/apache/flink/pull/24271#discussion_r1479341371
##
docs/setup_docs.sh:
##
@@ -36,24 +36,34 @@ function integrate_connector_docs {
}
+SKIP_INTEGRATE_CONNECTOR_DOCS=false
+for arg in "$@"; do
+ if [ "$arg"
flinkbot commented on PR #24271:
URL: https://github.com/apache/flink/pull/24271#issuecomment-1928665414
## CI report:
* 5d0094be3680b0a36ea2ffccac1add228368b1b5 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
swuferhong opened a new pull request, #24271:
URL: https://github.com/apache/flink/pull/24271
## What is the purpose of the change
The current build process of Flink's documentation involves the
`setup_docs.sh` script, which re-clones connector repositories every time the
