Zakelly commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2116919484
I modified the commit message and remove those 'cherry-picked from x'.
Already merged into master.
--
This is an automated message from the Apache Git Service.
To respond to the
Zakelly closed pull request #24461: [FLINK-34615]Split
`ExternalizedCheckpointCleanup` out of `Checkpoint…
URL: https://github.com/apache/flink/pull/24461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2116868581
@Zakelly Flink-ci has passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2111766768
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2106510219
@Zakelly @masteryhx A new `ExternalizedCheckpointRetention.py` is created,
the old one is marked as deprecated, and a separate commit for the python part
is split.
--
This is an
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2105643136
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Zakelly commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2102128570
@spoon-lz sorry for the late reply. I agreed with @masteryhx that we'd
better create another new class and deprecate the old one in python.
--
This is an automated message from the
masteryhx commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1591876771
##
flink-python/docs/reference/pyflink.datastream/checkpoint.rst:
##
@@ -81,7 +81,7 @@ The default limit of concurrently happening checkpoints: one.
masteryhx commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1591864040
##
flink-python/docs/reference/pyflink.datastream/checkpoint.rst:
##
@@ -81,7 +81,7 @@ The default limit of concurrently happening checkpoints: one.
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2097311563
@Zakelly @masteryhx What further discussions are needed on the modification
of the python part? This PR has been on hold for some time.
--
This is an automated message from the
spoon-lz commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1568676454
##
flink-python/docs/reference/pyflink.datastream/checkpoint.rst:
##
@@ -81,7 +81,7 @@ The default limit of concurrently happening checkpoints: one.
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2049266369
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Zakelly commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1560407149
##
flink-python/docs/reference/pyflink.datastream/checkpoint.rst:
##
@@ -81,7 +81,7 @@ The default limit of concurrently happening checkpoints: one.
masteryhx commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1560402211
##
flink-python/docs/reference/pyflink.datastream/checkpoint.rst:
##
@@ -81,7 +81,7 @@ The default limit of concurrently happening checkpoints: one.
spoon-lz commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1560395390
##
flink-python/docs/reference/pyflink.datastream/checkpoint.rst:
##
@@ -81,7 +81,7 @@ The default limit of concurrently happening checkpoints: one.
spoon-lz commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1560395390
##
flink-python/docs/reference/pyflink.datastream/checkpoint.rst:
##
@@ -81,7 +81,7 @@ The default limit of concurrently happening checkpoints: one.
masteryhx commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2048809222
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
masteryhx commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1560348981
##
flink-python/docs/reference/pyflink.datastream/checkpoint.rst:
##
@@ -81,7 +81,7 @@ The default limit of concurrently happening checkpoints: one.
Zakelly commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2048808031
> @masteryhx Hi,this pr blocks another pr. Can you help me take a look? By
the way, this change caused a python test error. Since I don’t have much
experience in using python, I modified
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2047043775
@masteryhx Hi,this pr blocks another pr. Can you help me take a look? By the
way, this change caused a python test error. Since I don’t have much experience
in using python, I modified
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2031643286
@Zakelly @masteryhx The code has been adjusted, please help me take a look
again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2031422386
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2031220990
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2030958637
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
spoon-lz commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1537179304
##
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceRescaleITCase.java:
##
@@ -122,8 +121,9 @@
spoon-lz commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1537133888
##
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceRescaleITCase.java:
##
@@ -122,8 +121,9 @@
masteryhx commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1535027271
##
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceRescaleITCase.java:
##
@@ -122,8 +121,9 @@
masteryhx commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1535027271
##
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceRescaleITCase.java:
##
@@ -122,8 +121,9 @@
Zakelly commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1534971391
##
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceRescaleITCase.java:
##
@@ -122,8 +121,9 @@
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-1999140065
@Zakelly The code has been modified, please take a look again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-1997040433
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Zakelly commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1521260155
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java:
##
@@ -520,12 +521,40 @@ public void
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-1984923835
@Zakelly Please help me take a look at this PR to see if it meets the
requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
flinkbot commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-1982873796
## CI report:
* 6c3c70c4d0fe086e8dd0e65533ff5dabb7265f7d UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
spoon-lz opened a new pull request, #24461:
URL: https://github.com/apache/flink/pull/24461
…Config` and move it to flink-core.
## What is the purpose of the change
In FLIP-406 we want to merge all options from ExecutionCheckpointingOptions
into CheckpointingOptions.
35 matches
Mail list logo
