Mrart commented on PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2148692911
@leonardBang Can you help me review it again？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Mrart commented on PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2132210507
> > I think we can specific a config prefix pass config to tikv client like
cdc source connector pass config to debezium by `debezium.*`. This way will be
flexible. @leonardBang @Mrart
GOODBOY008 commented on PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2132201295
As discuss offline with @Mrart , due to ``tikvclient` config `hostMapping`
different from others. So the solution in this PR, I think ok.
--
This is an automated message from the
Mrart commented on PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2124764340
> I think we can specific a config prefix pass config to tikv client like
cdc source connector pass config to debezium by `debezium.*`. This way will be
flexible. @leonardBang @Mrart cc
GOODBOY008 commented on PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2124044327
I think we can specific a config prefix pass config to tikv client like cdc
source connector pass config to debezium by `debezium.*`. This way will be
flexible. @leonardBang @Mrart
Mrart commented on code in PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#discussion_r1608399656
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/TDBSourceOptions.java:
##
@@ -82,10 +90,13
leonardBang commented on code in PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#discussion_r1608027592
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/TDBSourceOptions.java:
##
@@ -82,10
Mrart opened a new pull request, #3336:
URL: https://github.com/apache/flink-cdc/pull/3336
In tidb production environment deployment, there are usually two kinds of
network: internal network and public network. When we use pd mode in tikv, we
need to do network mapping, such as
