[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2020-01-06 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008727#comment-17008727 ] Xintong Song commented on FLINK-15103: -- Thanks for spending time investigating the regression,

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-10 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992459#comment-16992459 ] Xintong Song commented on FLINK-15103: -- BTW, [~pnowojski] could you please assign this ticket to

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-10 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992451#comment-16992451 ] Xintong Song commented on FLINK-15103: -- [~pnowojski] Totally agree on the suggested documentation

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-10 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992396#comment-16992396 ] Piotr Nowojski commented on FLINK-15103: FLINK-15172 sound interesting. {quote} I think we have

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-10 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992376#comment-16992376 ] Xintong Song commented on FLINK-15103: -- [~lzljs3620320], thanks for the input. I think the

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-10 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992352#comment-16992352 ] Jingsong Lee commented on FLINK-15103: -- [~xintongsong] , You remain me to test small batch sql

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-10 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992338#comment-16992338 ] Xintong Song commented on FLINK-15103: -- Sure. I can configure them to use the same amount of

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-10 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992317#comment-16992317 ] Piotr Nowojski commented on FLINK-15103: [~xintongsong] thanks for analysing this. I was

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-09 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992220#comment-16992220 ] Xintong Song commented on FLINK-15103: -- Ok, I think I find the cause of the regression. I’ll

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-09 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992128#comment-16992128 ] Xintong Song commented on FLINK-15103: -- True, I was also discussing this issue with [~yunta], who

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-09 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991704#comment-16991704 ] Piotr Nowojski commented on FLINK-15103: [~xintongsong] [~azagrebin], [~sewen] was explaining to

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-09 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991235#comment-16991235 ] Piotr Nowojski commented on FLINK-15103: I've created a ticket for that:

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-09 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991231#comment-16991231 ] Xintong Song commented on FLINK-15103: -- [~pnowojski], [~sewen] Sorry, it was my mistake to mark

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990847#comment-16990847 ] Stephan Ewen commented on FLINK-15103: -- Fully agree with the {{[hotfix]}} assessment, this was more

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990784#comment-16990784 ] Piotr Nowojski commented on FLINK-15103: I think that would be ok, however bigger question from

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-07 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990701#comment-16990701 ] Stephan Ewen commented on FLINK-15103: -- We can set the managed memory to 0 in those benchmarks (if

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990039#comment-16990039 ] Xintong Song commented on FLINK-15103: -- bq. I was doing the git bisect locally and I'm almost sure

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989971#comment-16989971 ] Piotr Nowojski commented on FLINK-15103: I was doing the git bisect locally and I'm almost sure

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989806#comment-16989806 ] Xintong Song commented on FLINK-15103: -- [~pnowojski], thanks for the pointer. I'll look into them

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989795#comment-16989795 ] Piotr Nowojski commented on FLINK-15103: {quote} I assume these operators with regression mainly

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989746#comment-16989746 ] Xintong Song commented on FLINK-15103: -- The memory management commits do change the default memory

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989733#comment-16989733 ] Chesnay Schepler commented on FLINK-15103: -- Ah, I looked at the tupleKeyBy run. > Performance

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989724#comment-16989724 ] Piotr Nowojski commented on FLINK-15103: Fixed (estimated range based on the arrayKeyBy

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989722#comment-16989722 ] Chesnay Schepler commented on FLINK-15103: -- [~azagrebin] [~xintongsong] > Performance

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989719#comment-16989719 ] Chesnay Schepler commented on FLINK-15103: -- The memory management changes are contained in that

[jira] [Commented] (FLINK-15103) Performance regression on 3.12.2019 in various benchmarks

2019-12-06 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989704#comment-16989704 ] Chesnay Schepler commented on FLINK-15103: -- {{git log 8403fd4..60b3f2f}} doesn't print anything