[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq

2015-04-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488176#comment-14488176 ] ASF GitHub Bot commented on FLINK-1847: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq

2015-04-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488020#comment-14488020 ] ASF GitHub Bot commented on FLINK-1847: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq

2015-04-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487956#comment-14487956 ] ASF GitHub Bot commented on FLINK-1847: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq

2015-04-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487267#comment-14487267 ] ASF GitHub Bot commented on FLINK-1847: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq

2015-04-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487089#comment-14487089 ] Till Rohrmann commented on FLINK-1847: -- I strongly agree with this policy. > Change

[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq

2015-04-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485228#comment-14485228 ] Stephan Ewen commented on FLINK-1847: - I am actually seeing a common Scala pitfall her

[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq

2015-04-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485225#comment-14485225 ] Stephan Ewen commented on FLINK-1847: - Same holds for {{count()}}. Both changes are A

[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq

2015-04-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485217#comment-14485217 ] Stephan Ewen commented on FLINK-1847: - Also, {{collect}} should have parenthesis. It i