[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-04-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324804#comment-17324804 ] Till Rohrmann commented on FLINK-21133: --- Are we going to have a quick fix for this problem in

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-04-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322856#comment-17322856 ] Flink Jira Bot commented on FLINK-21133: This issue is assigned but has not received an update

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-03-23 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307116#comment-17307116 ] Kezhu Wang commented on FLINK-21133: [~sewen] [~becket_qin] Good news! > FLIP-27 Source does not

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-03-23 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307109#comment-17307109 ] Stephan Ewen commented on FLINK-21133: -- [~becket_qin] and me talked about this quickly: We agree,

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-03-23 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307100#comment-17307100 ] Kezhu Wang commented on FLINK-21133: [~trohrmann] [~pnowojski] [~becket_qin] [~sewen] Hi all, should

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-25 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290782#comment-17290782 ] Till Rohrmann commented on FLINK-21133: --- Yes, let's move this discussion to the FLIP-147

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-24 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290206#comment-17290206 ] Piotr Nowojski commented on FLINK-21133: I agree about that we might need to change the API

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-24 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290197#comment-17290197 ] Till Rohrmann commented on FLINK-21133: --- For #2, we should fail the stop-with-savepoint operation

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-24 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289922#comment-17289922 ] Piotr Nowojski commented on FLINK-21133: [~kezhuw] #2, if stop-with-savepoint fails, job can

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-22 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288477#comment-17288477 ] Kezhu Wang commented on FLINK-21133: [~trohrmann] Great summarization! About user-case#2, we may

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-22 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288467#comment-17288467 ] Piotr Nowojski commented on FLINK-21133: +1 for those use cases/semantics summarised by

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-22 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288340#comment-17288340 ] Till Rohrmann commented on FLINK-21133: --- Thanks for driving this discussion. I think a lot of

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-22 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288240#comment-17288240 ] Yun Gao commented on FLINK-21133: - Hi [~sewen] very thanks for the deep insights! {quote}To support

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-20 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287735#comment-17287735 ] Kezhu Wang commented on FLINK-21133: [~becket_qin] [~pnowojski] [~sewen] Thanks all for recently

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-19 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287451#comment-17287451 ] Jiangjie Qin commented on FLINK-21133: -- [~pnowojski] I might get a little confused about what

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287105#comment-17287105 ] Piotr Nowojski commented on FLINK-21133: [~becket_qin] I think you are missing the

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-18 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286380#comment-17286380 ] Jiangjie Qin commented on FLINK-21133: -- It looks that we are aiming to get a long term solution

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-16 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285367#comment-17285367 ] Stephan Ewen commented on FLINK-21133: -- The complexity of adding a new {{EndOfData}} event, versus

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-16 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285319#comment-17285319 ] Kezhu Wang commented on FLINK-21133: {quote}But this assumption doesn't hold with the legacy

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285219#comment-17285219 ] Piotr Nowojski commented on FLINK-21133: {quote} Given all above, I would say

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285209#comment-17285209 ] Piotr Nowojski commented on FLINK-21133: As I have mentioned in the FLINK-21132, in principle I

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-16 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285207#comment-17285207 ] Kezhu Wang commented on FLINK-21133: {quote}I think what stop-with-savepoint should really do is

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-16 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285118#comment-17285118 ] Stephan Ewen commented on FLINK-21133: -- Alternatively, we could also have one EndOfPartition event,

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-12 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283631#comment-17283631 ] Stephan Ewen commented on FLINK-21133: -- I see, the remaining problem is that exiting the mailbox

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-10 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282564#comment-17282564 ] Kezhu Wang commented on FLINK-21133: {quote}I think what stop-with-savepoint should really do is

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-10 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282454#comment-17282454 ] Stephan Ewen commented on FLINK-21133: -- I think that the "stop()" method should be on

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-10 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282449#comment-17282449 ] Stephan Ewen commented on FLINK-21133: -- It looks to me like "stop with savepoint" it itself

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-09 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282263#comment-17282263 ] Kezhu Wang commented on FLINK-21133: [~becket_qin] Sorry for not aware of your comment, I am writing

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-09 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282253#comment-17282253 ] Kezhu Wang commented on FLINK-21133: Hi all, there are actually two cases for FLIP-27 sources not

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-09 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282226#comment-17282226 ] Jiangjie Qin commented on FLINK-21133: -- [~mapohl] [~kezhuw], thanks for digging into the issue. The

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-09 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281821#comment-17281821 ] Matthias commented on FLINK-21133: -- The error I described above was caused by not enabling Checkpoints.

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-09 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281693#comment-17281693 ] Till Rohrmann commented on FLINK-21133: --- fyi [~jqin], [~aljoscha] > FLIP-27 Source does not work

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-08 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281581#comment-17281581 ] Matthias commented on FLINK-21133: -- Findings mentioned in duplicate FLINK-21323: {quote} When looking