[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-15 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301598#comment-17301598 ] Xintong Song commented on FLINK-21419: -- Since we have reached consensus, I created FLINK-21798 for

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-15 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301573#comment-17301573 ] Xintong Song commented on FLINK-21419: -- bq. Shall we create an umbrella ticket for collecting all

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-15 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301564#comment-17301564 ] Till Rohrmann commented on FLINK-21419: --- +1 for your proposal [~xintongsong]. Shall we create an

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-15 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301504#comment-17301504 ] Kezhu Wang commented on FLINK-21419: [~xintongsong] Thanks for the backgrounds and explanation. With

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-15 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301484#comment-17301484 ] Xintong Song commented on FLINK-21419: -- Backgrounds: - GC cleaner was fist introduced in

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-15 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301408#comment-17301408 ] Kezhu Wang commented on FLINK-21419: Glad to see, we all lean to fail concurrent free by default, at

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-14 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301350#comment-17301350 ] Xintong Song commented on FLINK-21419: -- [~trohrmann] [~kezhuw], *Concurrent/multiple frees:* I

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-12 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300222#comment-17300222 ] Kezhu Wang commented on FLINK-21419: # detecting concurrent frees: To detect and guard concurrent

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-12 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300218#comment-17300218 ] Till Rohrmann commented on FLINK-21419: --- I agree with [~kezhuw] that multiple frees are a misuse

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-12 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300154#comment-17300154 ] Xintong Song commented on FLINK-21419: -- Just to clarify, the {{finalize()}} and

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-12 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300153#comment-17300153 ] Xintong Song commented on FLINK-21419: -- [~kezhuw], I'd be fine with explicitly fail on concurrent

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-12 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300149#comment-17300149 ] Kezhu Wang commented on FLINK-21419: >From all my experiences, native resources should always be

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-12 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300138#comment-17300138 ] Kezhu Wang commented on FLINK-21419: Hi [~xintongsong] & [~nicholasjiang], I think the cause of

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-11 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300013#comment-17300013 ] Nicholas Jiang commented on FLINK-21419: Thanks for [~kezhuw] reporting.  It's my mistake for no

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1736#comment-1736 ] Xintong Song commented on FLINK-21419: -- Thanks for the notice, [~kezhuw]. Double-freeing of native

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-03-11 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299989#comment-17299989 ] Kezhu Wang commented on FLINK-21419: Coming from FLINK-21728, given the severity of native memory

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-02-25 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291353#comment-17291353 ] Xintong Song commented on FLINK-21419: -- Thanks [~nicholasjiang]. You're assigned. Please go ahead.

[jira] [Commented] (FLINK-21419) Remove GC cleaner mechanism for unsafe memory segments

2021-02-25 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291350#comment-17291350 ] Nicholas Jiang commented on FLINK-21419: [~xintongsong], because of no performace effect, I