[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221971#comment-17221971 ] Robert Metzger commented on FLINK-8357: --- Resolved on master in

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196060#comment-17196060 ] Jörn Kottmann commented on FLINK-8357: -- Ok, thats how we will do it, I will start working on the PR

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196044#comment-17196044 ] Robert Metzger commented on FLINK-8357: --- I think your timestmap requirement is specific to your

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196043#comment-17196043 ] Jörn Kottmann commented on FLINK-8357: -- Sounds good to me, you are right the time based rotations is

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195991#comment-17195991 ] Robert Metzger commented on FLINK-8357: --- I'm a bit skeptical if a one-hour rotation is the best

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195667#comment-17195667 ] Jörn Kottmann commented on FLINK-8357: -- Kafka is using hourly rotating logs without a max size. This

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194218#comment-17194218 ] Robert Metzger commented on FLINK-8357: --- Thanks a lot for working on this! For the file size,

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194194#comment-17194194 ] Jörn Kottmann commented on FLINK-8357: -- Actually I still really need to get this fixed, let me just

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194175#comment-17194175 ] Robert Metzger commented on FLINK-8357: --- [~joern] are you still working on this? Otherwise, I'd

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110304#comment-17110304 ] Till Rohrmann commented on FLINK-8357: -- Hi [~joern], to what size would you set the rolling policy?

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103029#comment-17103029 ] Jörn Kottmann commented on FLINK-8357: -- I am happy to work on this. > enable rolling in default log

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062697#comment-17062697 ] Stephan Ewen commented on FLINK-8357: - Reopened as a recurring issue. > enable rolling in default

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058521#comment-17058521 ] Jörn Kottmann commented on FLINK-8357: -- It would still be good to make this the default, I was

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583977#comment-16583977 ] ASF GitHub Bot commented on FLINK-8357: --- GJL commented on issue #5371: [FLINK-8357] [conf] Enable

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394784#comment-16394784 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394778#comment-16394778 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393051#comment-16393051 ] ASF GitHub Bot commented on FLINK-8357: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350363#comment-16350363 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349948#comment-16349948 ] ASF GitHub Bot commented on FLINK-8357: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347921#comment-16347921 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347909#comment-16347909 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347910#comment-16347910 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347312#comment-16347312 ] ASF GitHub Bot commented on FLINK-8357: --- Github user XuMingmin commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347311#comment-16347311 ] ASF GitHub Bot commented on FLINK-8357: --- Github user XuMingmin commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346376#comment-16346376 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346201#comment-16346201 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346161#comment-16346161 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346159#comment-16346159 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346162#comment-16346162 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345905#comment-16345905 ] ASF GitHub Bot commented on FLINK-8357: --- Github user XuMingmin commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345907#comment-16345907 ] ASF GitHub Bot commented on FLINK-8357: --- Github user XuMingmin commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345906#comment-16345906 ] ASF GitHub Bot commented on FLINK-8357: --- Github user XuMingmin commented on a diff in the pull

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343270#comment-16343270 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343265#comment-16343265 ] ASF GitHub Bot commented on FLINK-8357: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340825#comment-16340825 ] ASF GitHub Bot commented on FLINK-8357: --- GitHub user zhangminglei opened a pull request:

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340755#comment-16340755 ] mingleizhang commented on FLINK-8357: - Thanks [~mingmxu]. I will take a look. > enable rolling in

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313060#comment-16313060 ] Stephan Ewen commented on FLINK-8357: - Sounds like a good idea. > enable rolling in default log