boring-cyborg[bot] commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1972726428
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
MartijnVisser merged PR #72:
URL: https://github.com/apache/flink-connector-jdbc/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
whhe commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1970654657
Anyone available please take a look on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
whhe commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1963261767
Hi @MartijnVisser @eskabetxe can we continue the review when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
whhe commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1918992897
@eskabetxe PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
davidradl commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1887018227
> Hello @MartijnVisser @davidradl Is it OK to keep the driver with 'provide'
or 'test' scope here? If not, I may have to remove it and disable other IT
cases in order to make
whhe commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1886811738
Hello @MartijnVisser @davidradl Is it OK to keep the driver with 'provide'
or 'test' scope here? If not, I may have to remove it and disable other IT
cases in order to make the CI
whhe commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1886803110
@eskabetxe Please take a look on this if you are available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
whhe commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1886799276
I added a test case in oracle mode, but because there is no docker
environment, it can only be executed locally.
Below is the output of testing after I set the connection
whhe commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410409235
##
flink-connector-jdbc/pom.xml:
##
@@ -110,6 +110,13 @@ under the License.
provided
+
+
MartijnVisser commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410313686
##
flink-connector-jdbc/pom.xml:
##
@@ -110,6 +110,13 @@ under the License.
provided
+
+
whhe commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410134563
##
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oceanbase/table/OceanBaseMySqlDynamicTableSinkITCase.java:
##
@@ -0,0 +1,92 @@
whhe commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410130574
##
flink-connector-jdbc/pom.xml:
##
@@ -110,6 +110,13 @@ under the License.
provided
+
+
whhe commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410125605
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialectFactory.java:
##
@@ -46,4 +46,14 @@ public interface JdbcDialectFactory
whhe commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410120366
##
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oceanbase/dialect/OceanBaseMysqlDialectTypeTest.java:
##
@@ -0,0 +1,77 @@
+/*
+
whhe commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410105087
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/oceanbase/dialect/OceanBaseRowConverter.java:
##
@@ -0,0 +1,158 @@
+/*
+ *
davidradl commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1409587288
##
flink-connector-jdbc/pom.xml:
##
@@ -110,6 +110,13 @@ under the License.
provided
+
+
davidradl commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1409587288
##
flink-connector-jdbc/pom.xml:
##
@@ -110,6 +110,13 @@ under the License.
provided
+
+
eskabetxe commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1409480831
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/oceanbase/dialect/OceanBaseRowConverter.java:
##
@@ -0,0 +1,158 @@
+/*
+ *
MartijnVisser commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1831974872
@eskabetxe Do you want to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
whhe commented on PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1784387778
I enabled the it cases for Mysql mode of OceanBase, and the ci generally
passed. PTAL @leonardBang @MartijnVisser
--
This is an automated message from the Apache Git Service.
To
21 matches
Mail list logo
