Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

LadyForest closed pull request #23678: [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default URL: https://github.com/apache/flink/pull/23678 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1429393701 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSourceFactory.java: ## @@ -141,15 +143,15 @@ private

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

LadyForest commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1429375718 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSourceFactory.java: ## @@ -141,15 +143,15 @@ private

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on PR #23678: URL: https://github.com/apache/flink/pull/23678#issuecomment-1855638485 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1423393030 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -297,10 +295,104 @@ void

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1423393030 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -297,10 +295,104 @@ void

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1423385053 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSourceFactory.java: ## @@ -141,15 +143,15 @@ private

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

LadyForest commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1423376727 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -297,10 +295,104 @@ void

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1421917082 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenConnectorOptions.java: ## @@ -118,10 +118,10 @@ public

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1421917082 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenConnectorOptions.java: ## @@ -118,10 +118,10 @@ public

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1421910481 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/RandomGeneratorVisitor.java: ## @@ -489,6 +465,16 @@ protected

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

LadyForest commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1421891193 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenConnectorOptions.java: ## @@ -118,10 +118,10 @@ public

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on PR #23678: URL: https://github.com/apache/flink/pull/23678#issuecomment-1839898221 @LadyForest I have updated commits and rebased on the latest branch, now CI passed, PLAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on PR #23678: URL: https://github.com/apache/flink/pull/23678#issuecomment-1835872939 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on PR #23678: URL: https://github.com/apache/flink/pull/23678#issuecomment-1835806974 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1411842995 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSourceFactory.java: ## @@ -127,11 +132,53 @@ private

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1411839904 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -215,6 +216,100 @@ void

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1411815025 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/RandomGeneratorVisitor.java: ## @@ -152,25 +142,20 @@ public

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

LadyForest commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1410315513 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSourceFactory.java: ## @@ -127,11 +132,53 @@ private

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1404708247 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/RandomGeneratorVisitor.java: ## @@ -135,7 +135,7 @@ public