yigress commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1779823630
yay! thank you @pnowojski for your time on the reviews! really appreciate
the learning from you!
--
This is an automated message from the Apache Git Service.
To respond to the message,
pnowojski commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1779343032
Thanks @yigress for your contribution! Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pnowojski merged PR #23425:
URL: https://github.com/apache/flink/pull/23425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yigress commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1778479885
@pnowojski I rebased and it kicked off a rerun successfully. I also run some
job for a day without problem. if looks good can you help merge it too? thank
you so much!
--
This is an
pnowojski commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1776690248
@yigress , can you force push something into this branch? For example rebase
your code and force-push. That will trigger the build.
--
This is an automated message from the Apache
yigress commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1775778599
@pnowojski the command flinkbot run azure didn't kick off new runs. I can't
start a re-run either.
--
This is an automated message from the Apache Git Service.
To respond to the
yigress commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1775637374
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pnowojski commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1774965429
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
yigress commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1774447810
@pnowojski could you review again? appreciate every constructive review you
gave!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1367568947
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +81,19 @@ public void cleanCheckpoint(
boolean
yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1367568908
##
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##
@@ -109,6 +109,19 @@ public class CheckpointingOptions {
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r137562
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +81,19 @@ public void cleanCheckpoint(
boolean
yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1366104698
##
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##
@@ -109,6 +109,20 @@ public class CheckpointingOptions {
yigress commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1771447069
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1365015056
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +70,26 @@ public void cleanCheckpoint(
boolean
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1365013893
##
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##
@@ -109,6 +109,20 @@ public class CheckpointingOptions {
yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1364888361
##
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##
@@ -109,6 +109,20 @@ public class CheckpointingOptions {
yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1364762331
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +70,26 @@ public void cleanCheckpoint(
boolean
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1363482855
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +70,26 @@ public void cleanCheckpoint(
boolean
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1363482855
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +70,26 @@ public void cleanCheckpoint(
boolean
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1363482855
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +70,26 @@ public void cleanCheckpoint(
boolean
yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1362546056
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +70,26 @@ public void cleanCheckpoint(
boolean
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1361791271
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -71,10 +70,26 @@ public void cleanCheckpoint(
boolean
yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1361552392
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -73,8 +83,12 @@ public void cleanCheckpoint(
Executor
yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1361551024
##
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##
@@ -109,6 +109,20 @@ public class CheckpointingOptions {
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1358183466
##
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##
@@ -109,6 +109,20 @@ public class CheckpointingOptions {
pnowojski commented on PR #23425:
URL: https://github.com/apache/flink/pull/23425#issuecomment-1761419453
Thanks for the contribution. It looks like a nice improvement. I've left one
comment that could simplify the code/architecture a bit.
--
This is an automated message from the Apache
pnowojski commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1358178168
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##
@@ -73,8 +83,12 @@ public void cleanCheckpoint(
Executor
28 matches
Mail list logo
