Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-29 Thread via GitHub
pnowojski merged PR #23679: URL: https://github.com/apache/flink/pull/23679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-29 Thread via GitHub
pnowojski commented on PR #23679: URL: https://github.com/apache/flink/pull/23679#issuecomment-1832322834 Thanks! Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-21 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1401482553 ## flink-clients/src/main/java/org/apache/flink/client/cli/CheckpointOptions.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-21 Thread via GitHub
JingGe commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1400838655 ## flink-clients/src/main/java/org/apache/flink/client/cli/CheckpointOptions.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-10 Thread via GitHub
Zakelly commented on PR #23679: URL: https://github.com/apache/flink/pull/23679#issuecomment-1805307753 > Can you squash the latest two fixup commits into the first two commits: > > ``` > [[FLINK-6755] Support manual checkpoints triggering from

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-10 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1389074605 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does not

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-09 Thread via GitHub
pnowojski commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1388122630 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-09 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387824909 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does not

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-09 Thread via GitHub
pnowojski commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387811609 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-09 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387803896 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does not

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-09 Thread via GitHub
pnowojski commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387716143 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-08 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387577165 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java: ## @@ -842,6 +844,85 @@ private void disposeSavepoint( logAndSysout("Savepoint '"

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-08 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387573143 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java: ## @@ -611,6 +636,22 @@ public static void printHelpForSavepoint(Collection

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-08 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387572052 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does not

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-08 Thread via GitHub
pnowojski commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1386250291 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java: ## @@ -611,6 +636,22 @@ public static void printHelpForSavepoint(Collection

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-07 Thread via GitHub
Zakelly commented on PR #23679: URL: https://github.com/apache/flink/pull/23679#issuecomment-1800938033 Hi, @pnowojski @masteryhx Would you please take a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-07 Thread via GitHub
flinkbot commented on PR #23679: URL: https://github.com/apache/flink/pull/23679#issuecomment-1798294190 ## CI report: * bd404c8dad2c78dc5106fde39e3f81a689b90c85 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`