[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132128284 +1 for having two different methods by return type but we need more comments from @tillrohrmann, @thvasilo or other people because I'm not sure this is best approach.

[jira] [Commented] (FLINK-2448) registerCacheFile fails with MultipleProgramsTestbase

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700983#comment-14700983 ] ASF GitHub Bot commented on FLINK-2448: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-2448]Clear cache file list in Execution...

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1031#issuecomment-132136444 I am not sure this is solving it the right way. I find it more intuitive if cache files stay registered. They are part of the environment and should be sticky, like

[GitHub] flink pull request: [FLINK-2448]Clear cache file list in Execution...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1031#issuecomment-132140770 I'm not sure if I can form an opinion on this. I personally haven't used them at all with Flink, only with Hadoop. A call to clear cache files certainly makes

[jira] [Commented] (FLINK-2448) registerCacheFile fails with MultipleProgramsTestbase

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701000#comment-14701000 ] ASF GitHub Bot commented on FLINK-2448: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132146208 Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [flink-2532]fix the function name and the vari...

2015-08-18 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/1025#issuecomment-132153447 Hey @Rucongzhang, As this is your first contribution to Flink and the PR was issued before a relevant notice on the developer mailing list that advises against

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132170286 @thvasilo , @chiwanpark , I've made the required changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-2529) fix on some unused code for flink-runtime

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701077#comment-14701077 ] ASF GitHub Bot commented on FLINK-2529: --- Github user HuangWHWHW commented on the

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132118352 What about having two different functions? One for Discrete and one for continuous? Or perhaps just one for the Continuous as that is more likely to be used.

[jira] [Updated] (FLINK-2540) LocalBufferPool.requestBuffer gets into infinite loop

2015-08-18 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-2540: --- Component/s: Core LocalBufferPool.requestBuffer gets into infinite loop

[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code

2015-08-18 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132172991 @StephanEwen Thank you! Do you mean that this PR would not be closed and I can push future checks in this? --- If your project is set up for it, you can

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132134747 Okay. That sounds good enough. Can we make a final decision then? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132138231 The change in the execution class is good. I'll leave the other check in, as it is a good sanity check against future mistakes. --- If your project is set up for

[jira] [Created] (FLINK-2540) LocalBufferPool.requestBuffer gets into infinite loop

2015-08-18 Thread Gabor Gevay (JIRA)
Gabor Gevay created FLINK-2540: -- Summary: LocalBufferPool.requestBuffer gets into infinite loop Key: FLINK-2540 URL: https://issues.apache.org/jira/browse/FLINK-2540 Project: Flink Issue Type:

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701026#comment-14701026 ] ASF GitHub Bot commented on FLINK-1901: --- Github user ChengXiangLi commented on the

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-18 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/949#issuecomment-132152536 Hi, @tillrohrmann , do you have sometime to continue to review this PR and help to push its progress? --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-2366) HA Without ZooKeeper

2015-08-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700876#comment-14700876 ] Stephan Ewen commented on FLINK-2366: - The leader election service is pluggable in

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132115823 Looks good to merge except one cosmetic issue. Awesome job! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-1962) Add Gelly Scala API

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700903#comment-14700903 ] ASF GitHub Bot commented on FLINK-1962: --- Github user chiwanpark commented on the

[jira] [Commented] (FLINK-2477) Add test for SocketClientSink

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700841#comment-14700841 ] ASF GitHub Bot commented on FLINK-2477: --- Github user HuangWHWHW commented on the

[GitHub] flink pull request: [FLINK-2477][Add]Add tests for SocketClientSin...

2015-08-18 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/977#issuecomment-132100631 @StephanEwen Hi, I`m really very sorry to bother you again. I just wonder whether this can be merged or I need to do some fix more or close this PR? --- If

[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1015#issuecomment-132118469 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2

2015-08-18 Thread PieterJanVanAeken
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132118620 I fixed the unneccessary comment and did a quick rebase to keep up with master branch. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-2521) Add automatic test name logging for tests

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700918#comment-14700918 ] ASF GitHub Bot commented on FLINK-2521: --- Github user StephanEwen commented on the

[jira] [Commented] (FLINK-2366) HA Without ZooKeeper

2015-08-18 Thread Suminda Dharmasena (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700776#comment-14700776 ] Suminda Dharmasena commented on FLINK-2366: --- Can you consider something more

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132116059 I think that we can merge this PR after we decide the return type of `createHistogram` method. Any other points seem okay. --- If your project is set up for it, you

[jira] [Created] (FLINK-2539) More unified code style for Scala code

2015-08-18 Thread Chiwan Park (JIRA)
Chiwan Park created FLINK-2539: -- Summary: More unified code style for Scala code Key: FLINK-2539 URL: https://issues.apache.org/jira/browse/FLINK-2539 Project: Flink Issue Type: Improvement

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132119301 All right, let's merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-1962) Add Gelly Scala API

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700927#comment-14700927 ] ASF GitHub Bot commented on FLINK-1962: --- Github user StephanEwen commented on the

[jira] [Commented] (FLINK-2521) Add automatic test name logging for tests

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700834#comment-14700834 ] ASF GitHub Bot commented on FLINK-2521: --- Github user tillrohrmann commented on the

[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...

2015-08-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1015#issuecomment-132097606 Good idea @StephanEwen, I'll make the log statements more prominent and then I'll merge the PR. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-1962) Add Gelly Scala API

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700901#comment-14700901 ] ASF GitHub Bot commented on FLINK-1962: --- Github user chiwanpark commented on a diff

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1004#discussion_r37273914 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala --- @@ -0,0 +1,735 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-1962) Add Gelly Scala API

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700920#comment-14700920 ] ASF GitHub Bot commented on FLINK-1962: --- Github user PieterJanVanAeken commented on

[GitHub] flink pull request: [FLINK-2477][Add]Add tests for SocketClientSin...

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/977#issuecomment-132118720 Looks good and CI passes. Will merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-2477) Add test for SocketClientSink

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700922#comment-14700922 ] ASF GitHub Bot commented on FLINK-2477: --- Github user StephanEwen commented on the

[jira] [Updated] (FLINK-2540) LocalBufferPool.requestBuffer gets into infinite loop

2015-08-18 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-2540: --- Fix Version/s: 0.9.1 0.10 LocalBufferPool.requestBuffer gets into infinite loop

[jira] [Created] (FLINK-2542) It should be documented that it is required from a join key to override hashCode(), when it is not a POJO

2015-08-18 Thread Gabor Gevay (JIRA)
Gabor Gevay created FLINK-2542: -- Summary: It should be documented that it is required from a join key to override hashCode(), when it is not a POJO Key: FLINK-2542 URL:

[jira] [Commented] (FLINK-2540) LocalBufferPool.requestBuffer gets into infinite loop

2015-08-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701179#comment-14701179 ] Stephan Ewen commented on FLINK-2540: - I put Ufuk as responsible for that (hop that's

[jira] [Updated] (FLINK-2540) LocalBufferPool.requestBuffer gets into infinite loop

2015-08-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-2540: Priority: Blocker (was: Major) LocalBufferPool.requestBuffer gets into infinite loop

[jira] [Updated] (FLINK-2540) LocalBufferPool.requestBuffer gets into infinite loop

2015-08-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-2540: Assignee: Ufuk Celebi LocalBufferPool.requestBuffer gets into infinite loop

[jira] [Commented] (FLINK-2508) Confusing sharing of StreamExecutionEnvironment

2015-08-18 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701196#comment-14701196 ] Márton Balassi commented on FLINK-2508: --- Thanks for both resports, Aljoscha. I am

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132187018 Olrite. I'll be back in a few. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-2488) Expose attemptNumber in RuntimeContext

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701218#comment-14701218 ] ASF GitHub Bot commented on FLINK-2488: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2488][FLINK-2496] Expose Task Manager c...

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1026#discussion_r37294536 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/TaskRuntimeInfo.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132183402 Is there the valid reason to have multiple names ('discrete histogram', 'categorical histogram')? I think that to avoid confusion, we need to unify the names. ---

[jira] [Created] (FLINK-2543) State handling does not support deserializing classes through the UserCodeClassloader

2015-08-18 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-2543: - Summary: State handling does not support deserializing classes through the UserCodeClassloader Key: FLINK-2543 URL: https://issues.apache.org/jira/browse/FLINK-2543

[jira] [Assigned] (FLINK-2543) State handling does not support deserializing classes through the UserCodeClassloader

2015-08-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-2543: - Assignee: Robert Metzger State handling does not support deserializing classes through

[jira] [Commented] (FLINK-2508) Confusing sharing of StreamExecutionEnvironment

2015-08-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701175#comment-14701175 ] Aljoscha Krettek commented on FLINK-2508: - Another problem I discovered is that

[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...

2015-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132188989 @chiwanpark , modified the names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2488][FLINK-2496] Expose Task Manager c...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1026#issuecomment-132198739 Rebased to the latest master. Can be merged now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-2488) Expose attemptNumber in RuntimeContext

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701217#comment-14701217 ] ASF GitHub Bot commented on FLINK-2488: --- Github user sachingoel0101 commented on the

[jira] [Created] (FLINK-2541) TypeComparator creation fails for T2T1byte[], byte[]

2015-08-18 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-2541: --- Summary: TypeComparator creation fails for T2T1byte[], byte[] Key: FLINK-2541 URL: https://issues.apache.org/jira/browse/FLINK-2541 Project: Flink

[jira] [Updated] (FLINK-2541) TypeComparator creation fails for T2T1byte[], byte[]

2015-08-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-2541: -- Component/s: Java API TypeComparator creation fails for T2T1byte[], byte[]

[jira] [Commented] (FLINK-2521) Add automatic test name logging for tests

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1470#comment-1470 ] ASF GitHub Bot commented on FLINK-2521: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-2521) Add automatic test name logging for tests

2015-08-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-2521. Resolution: Fixed Added via 2f0412f163f4d37605188c8cc763111e0b51f0dc Add automatic test name

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132186504 I'm also inclined to use Discrete. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132193111 They're not coupled at all. But both are related to statistics over data sets. This is why I combined them both in one. If you're wondering, there is a JIRA for

[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132196596 I'll merge half of this pull request... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2015-08-18 Thread Trevor Grant (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701200#comment-14701200 ] Trevor Grant commented on FLINK-1994: - I more or less have this working with a few new

[jira] [Commented] (FLINK-2529) fix on some unused code for flink-runtime

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701198#comment-14701198 ] ASF GitHub Bot commented on FLINK-2529: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-2488][FLINK-2496] Expose Task Manager c...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1026#issuecomment-132199820 Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-2488) Expose attemptNumber in RuntimeContext

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701227#comment-14701227 ] ASF GitHub Bot commented on FLINK-2488: --- Github user sachingoel0101 commented on the

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2015-08-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701225#comment-14701225 ] Till Rohrmann commented on FLINK-1994: -- Sounds great [~rawkintrevo]. When it's ready,

[jira] [Created] (FLINK-2545) NegativeArraySizeException while creating hash table bloom filters

2015-08-18 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-2545: - Summary: NegativeArraySizeException while creating hash table bloom filters Key: FLINK-2545 URL: https://issues.apache.org/jira/browse/FLINK-2545 Project: Flink

[jira] [Commented] (FLINK-2545) NegativeArraySizeException while creating hash table bloom filters

2015-08-18 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701802#comment-14701802 ] Stephan Ewen commented on FLINK-2545: - Thanks for reporting this! As a quick fix, you

[jira] [Commented] (FLINK-2488) Expose attemptNumber in RuntimeContext

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701814#comment-14701814 ] ASF GitHub Bot commented on FLINK-2488: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-2488][FLINK-2496] Expose Task Manager c...

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1026#issuecomment-132322001 Sorry to be picky again, but it would be good to harmonize the code style a bit - make it more consistent with the remaining code. What struck me in

[GitHub] flink pull request: Path refactor

2015-08-18 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1034 Path refactor You can merge this pull request into a Git repository by running: $ git pull https://github.com/gallenvara/flink path_refactor Alternatively you can review and apply these

[GitHub] flink pull request: [FLINK-2077] [core] Rework Path class and add ...

2015-08-18 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1035 [FLINK-2077] [core] Rework Path class and add extend support for Windows paths The class org.apache.flink.core.fs.Path handles paths for Flink's FileInputFormat and FileOutputFormat. Over time,

[jira] [Issue Comment Deleted] (FLINK-2366) HA Without ZooKeeper

2015-08-18 Thread Suminda Dharmasena (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suminda Dharmasena updated FLINK-2366: -- Comment: was deleted (was: OK. As long as it is *easily pluggable* it is OK. Also

[jira] [Commented] (FLINK-2366) HA Without ZooKeeper

2015-08-18 Thread Suminda Dharmasena (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702379#comment-14702379 ] Suminda Dharmasena commented on FLINK-2366: --- OK. As long as it is *easily

[jira] [Commented] (FLINK-2366) HA Without ZooKeeper

2015-08-18 Thread Suminda Dharmasena (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702380#comment-14702380 ] Suminda Dharmasena commented on FLINK-2366: --- OK. As long as it is *easily

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132439907 Including the collect step in the documentation seems weird, IMO. Since the return type is a `DataSet[Histogram]`, anyone familiar with flink will know to collect

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702304#comment-14702304 ] ASF GitHub Bot commented on FLINK-1901: --- Github user ChengXiangLi commented on a

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-18 Thread ChengXiangLi
Github user ChengXiangLi commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r37373497 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/util/PoissonSampler.java --- @@ -0,0 +1,109 @@ +/* + * Licensed to the

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1033#discussion_r37376484 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/GraphAlgorithm.scala --- @@ -0,0 +1,30 @@ +/* + * Licensed

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1033#discussion_r37376469 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala --- @@ -649,10 +650,13 @@ TypeInformation :

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1033#discussion_r37376477 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala --- @@ -649,10 +650,13 @@ TypeInformation :

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132430686 The only problem to merge this is invalid example in documentation. We need calling `collect()` method and `apply(0)` to execute statistics methods such as

[jira] [Commented] (FLINK-2077) Rework Path class and add extend support for Windows paths

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702375#comment-14702375 ] ASF GitHub Bot commented on FLINK-2077: --- GitHub user gallenvara opened a pull

[jira] [Commented] (FLINK-2488) Expose attemptNumber in RuntimeContext

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702524#comment-14702524 ] ASF GitHub Bot commented on FLINK-2488: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2488][FLINK-2496] Expose Task Manager c...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1026#issuecomment-132453057 @StephanEwen , I have fixed the styling issues as much as I could find out. Thanks for your patience. :) --- If your project is set up for it, you can reply

[GitHub] flink pull request: [Flink-2030][ml]Data Set Statistics and Histog...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-132449023 Hi @chiwanpark , I have modified the documentation to include the collect step. I have also made a few modification to how the histogram is created by using

[GitHub] flink pull request: [FLINK-2488][FLINK-2496] Expose Task Manager c...

2015-08-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1026#issuecomment-132449408 Sure thing. I'll fix it. IntelliJ re-formats used to take care of such things, but I've stopped using it recently as it was messing up scala code. --- If your

[jira] [Commented] (FLINK-2488) Expose attemptNumber in RuntimeContext

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702475#comment-14702475 ] ASF GitHub Bot commented on FLINK-2488: --- Github user sachingoel0101 commented on the

[jira] [Closed] (FLINK-2532) The function name and the variable name are same, it is confusing

2015-08-18 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-2532. - Resolution: Fixed Fix Version/s: 0.10 Via a9d55d3 The function name and the variable

[jira] [Commented] (FLINK-2477) Add test for SocketClientSink

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701357#comment-14701357 ] ASF GitHub Bot commented on FLINK-2477: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-1962) Add Gelly Scala API

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701355#comment-14701355 ] ASF GitHub Bot commented on FLINK-1962: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code

2015-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-2529) fix on some unused code for flink-runtime

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701356#comment-14701356 ] ASF GitHub Bot commented on FLINK-2529: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2

2015-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1004 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

2015-08-18 Thread PieterJanVanAeken
GitHub user PieterJanVanAeken opened a pull request: https://github.com/apache/flink/pull/1033 Add Scala version of GraphAlgorithm The Scala Gelly API already has a wrapper for running java-based GraphAlgorithms. It is needed for running pre-built algorithms such as the

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

2015-08-18 Thread PieterJanVanAeken
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-132241973 Please wait a sec with this one. Something is off with my local changes vs my repo changes. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2

2015-08-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132241841 If the APIs are in sync there should be one documentation for both, right? Similar as with the other APIs... --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-1962) Add Gelly Scala API

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701396#comment-14701396 ] ASF GitHub Bot commented on FLINK-1962: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code

2015-08-18 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132205784 Ha... Sorry for my English, just misunderstood the execution. I will learn more about the Thread class. --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-2529) fix on some unused code for flink-runtime

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701246#comment-14701246 ] ASF GitHub Bot commented on FLINK-2529: --- Github user HuangWHWHW commented on the

  1   2   >