[
https://issues.apache.org/jira/browse/FLINK-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723000#comment-14723000
]
ASF GitHub Bot commented on FLINK-2596:
---
GitHub user ChengXiangLi opened a pull request:
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1080#issuecomment-136276551
Looks good to merge. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723038#comment-14723038
]
ASF GitHub Bot commented on FLINK-2077:
---
Github user gallenvara closed the pull request at:
Github user gallenvara closed the pull request at:
https://github.com/apache/flink/pull/1035
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user ChengXiangLi opened a pull request:
https://github.com/apache/flink/pull/1080
[FLINK-2596] Failing Test: RandomSamplerTest
Remove the non-transitive comparator which cause this issue, default Double
comparator works just fine.
You can merge this pull request into a Git
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1079#issuecomment-136284408
From [this JIRA](https://issues.apache.org/jira/browse/HIVE-4460), It seems
that HCatalog are deployed with Hadoop 2. Is it sure that the vanila version of
HCatalog
[
https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723065#comment-14723065
]
ASF GitHub Bot commented on FLINK-2490:
---
Github user HuangWHWHW commented on the pull request:
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/992#issuecomment-136285250
@mxm
Hi, max.
Any comment about my new changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38382368
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724717#comment-14724717
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user ffbin commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-2599.
---
> Failing Test: SlotCountExceedingParallelismTest
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723555#comment-14723555
]
Trevor Grant commented on FLINK-1994:
-
Sorry for the delay on this- I've been in the middle of a move.
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136426216
@tillrohrmann While writing the new tests for both methods, I encountered
that `zipWithIndex` is broken, too. It sometimes throws
`ConcurrentModificationException`. This
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723667#comment-14723667
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user s1ck commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136427373
There is an issue that tracks the `ConcurrentModificationException`problem.
As per discussion in that issue, can you use a `BroadcastVariableInitializer`?
Safes
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723681#comment-14723681
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user StephanEwen commented on the pull request:
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136431165
@StephanEwen thx for the hint. works fine! Will cleanup and commit now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723701#comment-14723701
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user s1ck commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723779#comment-14723779
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user s1ck commented on the pull request:
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136445029
@tillrohrmann I did not include the `shifter =
getBitSize(getRuntimeContext().getNumberOfParallelSubtasks() - 1)` as your hint
only applies for power of 2 values. E.g.,
Github user ogokal commented on the pull request:
https://github.com/apache/flink/pull/1077#issuecomment-136486224
I changed unit tests as HuangWHWHW suggested, added a simple test server
socket and refactored test methods.
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723967#comment-14723967
]
ASF GitHub Bot commented on FLINK-2125:
---
Github user ogokal commented on the pull request:
Github user anisnasir commented on the pull request:
https://github.com/apache/flink/pull/1069#issuecomment-136496310
@tillrohrmann Yes, we can design a system that adapts to the load imbalance
and increases the number of partitions per key in real time. However, this
comes with few
[
https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724019#comment-14724019
]
ASF GitHub Bot commented on FLINK-1725:
---
Github user anisnasir commented on the pull request:
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/1077#discussion_r38378115
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketTextStreamFunctionTest.java
---
[
https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724537#comment-14724537
]
ASF GitHub Bot commented on FLINK-2125:
---
Github user HuangWHWHW commented on a diff in the pull
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/1077#discussion_r38378250
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketTextStreamFunctionTest.java
---
[
https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724542#comment-14724542
]
ASF GitHub Bot commented on FLINK-2125:
---
Github user HuangWHWHW commented on a diff in the pull
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136545997
Ah, thank you for the proof.
And didn`t see the log2 in detail before, sorry.
---
If your project is set up for it, you can reply to this email and have your
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724544#comment-14724544
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user HuangWHWHW commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723153#comment-14723153
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723160#comment-14723160
]
ASF GitHub Bot commented on FLINK-1725:
---
Github user tillrohrmann commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1069#issuecomment-136290092
@anisnasir, good to know that most real world data sets can be handled by
just splitting keys into two components. But what about the rest? Wouldn't it
be nice to
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723209#comment-14723209
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on the pull request:
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136302889
Travis run on Linux. There is only a single ":" in the path there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user JonathanH5 commented on the pull request:
https://github.com/apache/flink/commit/9e20147c2089d29e3071addec19f0956f68b7321#commitcomment-12972151
Hi Till,
as reported by me and @FelixNeutatz: the stop-script has the same error...
---
If your project is set up for
Matthias J. Sax created FLINK-2599:
--
Summary: Failing Test: SlotCountExceedingParallelismTest
Key: FLINK-2599
URL: https://issues.apache.org/jira/browse/FLINK-2599
Project: Flink
Issue
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1030#issuecomment-136285097
@tillrohrmann
Hi,very sorry for disturbing.
I have changed the PR as your comments and passed the CI.
It will be thankful if you can take a look.
---
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723212#comment-14723212
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user ffbin commented on the pull request:
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136301903
@mjsax Thanks.
I have a question:
In my windows machine, the textPath of ExclamationWithStormSpoutITCase is
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1016#issuecomment-136327681
Failing test is a Yarn test. Locally Travis passed. Will merge it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/FLINK-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723283#comment-14723283
]
ASF GitHub Bot commented on FLINK-2291:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723219#comment-14723219
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723310#comment-14723310
]
ASF GitHub Bot commented on FLINK-2584:
---
Github user rmetzger commented on the pull request:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1076#issuecomment-136339437
Make sure it does not break with @tillrohrmann's recent merge ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723206#comment-14723206
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user ffbin commented on the pull request:
Github user nltran commented on a diff in the pull request:
https://github.com/apache/flink/pull/967#discussion_r38295439
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/iterative/event/EventWithAggregatorsTest.java
---
@@ -123,6 +169,31 @@ private
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/commit/9e20147c2089d29e3071addec19f0956f68b7321#commitcomment-12973040
I'll fix it. Thanks for the pointer @JonathanH5 :-)
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/FLINK-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723298#comment-14723298
]
ASF GitHub Bot commented on FLINK-2596:
---
Github user StephanEwen commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1080#issuecomment-136335673
Thanks, will merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723305#comment-14723305
]
ASF GitHub Bot commented on FLINK-2584:
---
Github user StephanEwen commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1076#issuecomment-136336944
I'll merge this now into `master` and `0.10.0-milestone1`.
In the long run, we can hopefully convince curator to offer a shaded
version in addition to the
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136289777
This is the stack trace (occurs in 4/5 runs -- the other run failed before
due to unrelated test). It seems you broke something.
```
Tests run: 1, Failures: 1,
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136304296
Oh, So not all test case can run successfully in windows?
I have change this and commit again.
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/FLINK-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-2291.
Resolution: Fixed
Added via b9de4ed37ffa68ef50dc6d6b3819afcc00d1d029
> Use ZooKeeper to elect
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136305354
This might be the case. I never tried it. And as far as I know, all
developers work on Linux or Mac, so this was never an issue.
---
If your project is set up for it,
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1073#issuecomment-136357113
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jamescao commented on the pull request:
https://github.com/apache/flink/pull/1079#issuecomment-136359875
@chiwanpark
Yes, it's sure that the apache version of HCatalog is compiled against
hadoop1. Using this jar in an hadoop2 environment will lead to binary
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312505
--- Diff:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1075#discussion_r38305177
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -121,6 +122,7 @@ public void mapPartition(Iterable values,
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723413#comment-14723413
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312609
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/StormFileSpout.java
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723446#comment-14723446
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1472#comment-1472
]
Ozturk Gokal commented on FLINK-2125:
-
I will change test codes to use a test socket server as
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1081#issuecomment-136355256
Looks good, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312152
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723404#comment-14723404
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312112
--- Diff:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312165
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723406#comment-14723406
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723339#comment-14723339
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user StephanEwen commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136352327
+1 for a test, otherwise this looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723349#comment-14723349
]
ASF GitHub Bot commented on FLINK-2399:
---
Github user sachingoel0101 commented on the pull request:
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-136356151
Rebased to the current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723408#comment-14723408
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312340
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723407#comment-14723407
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136382814
@s1ck Good idea. You can also call `collect()`, add the IDs to a set and
make sure the set has the right cardinality. In general, avoiding temp files
and Strings
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723401#comment-14723401
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38311967
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormBoltWrapper.java
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723414#comment-14723414
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136380943
There is already a test case for zipWithUniqueId() in
[
https://issues.apache.org/jira/browse/FLINK-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723328#comment-14723328
]
ASF GitHub Bot commented on FLINK-2291:
---
Github user asfgit closed the pull request at:
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1031#issuecomment-136349300
@StephanEwen, this should be mergeable now.
I've separated the Gelly change as a second commit.
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/FLINK-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723326#comment-14723326
]
ASF GitHub Bot commented on FLINK-2448:
---
Github user sachingoel0101 commented on the pull request:
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1081
[core][runtime] move SerializedValueTest from runtime to core
- move createCopySerializable to core's CommonTestUtils
- rename CommonTestUtils createCopy to createCopyWritable
- adapt the tests
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/a18994aabfba7c3775f6dc911bd9d59016216817#commitcomment-12974542
In
flink-runtime/src/test/java/org/apache/flink/runtime/util/SerializedValueTest.java:
In
[
https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723355#comment-14723355
]
ASF GitHub Bot commented on FLINK-2480:
---
Github user mxm commented on the pull request:
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1082
[FLINK-2372] Add new FlinkKafkaProducer
This pull request is reworking Flink's KafkaSink.
I've renamed the class to `FlinkKafkaProducer` to match it with
`FlinkKafkaConsumer`.
It uses
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723400#comment-14723400
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38311822
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723411#comment-14723411
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723434#comment-14723434
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user s1ck commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723369#comment-14723369
]
ASF GitHub Bot commented on FLINK-2480:
---
Github user HuangWHWHW commented on the pull request:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312308
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723405#comment-14723405
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user mjsax commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723462#comment-14723462
]
ASF GitHub Bot commented on FLINK-2590:
---
Github user tillrohrmann commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136386406
@s1ck, the `testZipWithUniqueId` test is bogus. You can remove this test
case an replace it with your described test. It would also be great if you
could set the
1 - 100 of 106 matches
Mail list logo
