[jira] [Commented] (FLINK-2689) Reusing null object for joins with SolutionSet

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790633#comment-14790633 ] ASF GitHub Bot commented on FLINK-2689: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1134#discussion_r39650722 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/IntegerTypeInfo.java --- @@ -18,15 +18,33 @@ package

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790639#comment-14790639 ] ASF GitHub Bot commented on FLINK-2637: --- Github user chiwanpark commented on a diff in the pull

[jira] [Commented] (FLINK-2595) Unclosed JarFile may leak resource in ClassLoaderUtilsTest

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790675#comment-14790675 ] ASF GitHub Bot commented on FLINK-2595: --- GitHub user tedyu opened a pull request:

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/flink/pull/1137 FLINK-2595 Unclosed JarFile may leak resource in ClassLoaderUtilsTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/flink master

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140795134 I know. See dev mailing list "Java 8 JDK issue". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790672#comment-14790672 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on the pull request:

[jira] [Commented] (FLINK-2670) Unstable CombineTaskTest

2015-09-16 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790690#comment-14790690 ] Matthias J. Sax commented on FLINK-2670: It's up to you. If you think it was a one-time hick-up

[jira] [Commented] (FLINK-2613) Print usage information for Scala Shell

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790694#comment-14790694 ] ASF GitHub Bot commented on FLINK-2613: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2613] Print usage information for Scala...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1106#discussion_r39653423 --- Diff: flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupIT.scala --- @@ -0,0 +1,60 @@ +/* + *

[jira] [Updated] (FLINK-2595) Unclosed JarFile may leak resource in ClassLoaderUtilsTest

2015-09-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-2595: -- Description: Here is related code: {code} try { new

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1135#discussion_r39652292 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java ---

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790669#comment-14790669 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-2613) Print usage information for Scala Shell

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790679#comment-14790679 ] ASF GitHub Bot commented on FLINK-2613: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2613] Print usage information for Scala...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1106#discussion_r39652554 --- Diff: flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupIT.scala --- @@ -0,0 +1,60 @@ +/* + *

[jira] [Commented] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790869#comment-14790869 ] Chesnay Schepler commented on FLINK-2690: - It appears that FLINK-2684 collides with this issue, it

[GitHub] flink pull request: Feature/flink 2576

2015-09-16 Thread jkovacs
GitHub user jkovacs opened a pull request: https://github.com/apache/flink/pull/1138 Feature/flink 2576 This PR implements [FLINK-2576](https://issues.apache.org/jira/browse/FLINK-2576) (Adding the outer join operator to the optimizer and Java/Scala APIs, previously part of

[jira] [Commented] (FLINK-2576) Add outer joins to API and Optimizer

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791008#comment-14791008 ] ASF GitHub Bot commented on FLINK-2576: --- GitHub user jkovacs opened a pull request:

[jira] [Commented] (FLINK-2595) Unclosed JarFile may leak resource in ClassLoaderUtilsTest

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791021#comment-14791021 ] ASF GitHub Bot commented on FLINK-2595: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1137#discussion_r39676482 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java --- @@ -46,13 +46,16 @@ public void testWithURLClassLoader() {

[GitHub] flink pull request: Hits

2015-09-16 Thread mfahimazizi
Github user mfahimazizi commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-140871748 Hey @vasia, Thank you. sorry it is "calculate node values". first we label the edge as 'H' (hub score), then undirected the graph and label the new edges as

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1137#issuecomment-140868278 Hi @tedyu, Thanks for the pull request! It's good to merge after the the indention is fixed. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-2640) Integrate the off-heap configurations with YARN runner

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791035#comment-14791035 ] ASF GitHub Bot commented on FLINK-2640: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-2640][yarn] integrate off-heap configur...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1132#issuecomment-140869851 Thanks for the update. I will merge this PR tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-2595) Unclosed JarFile may leak resource in ClassLoaderUtilsTest

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791026#comment-14791026 ] ASF GitHub Bot commented on FLINK-2595: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-140877442 Hi @HuangWHWHW, your PR #1131 has been merged. Can you update this PR and remove those changes? Thanks! --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-2357) New JobManager Runtime Web Frontend

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791112#comment-14791112 ] ASF GitHub Bot commented on FLINK-2357: --- GitHub user StephanEwen opened a pull request:

[GitHub] flink pull request: Hits

2015-09-16 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-140903149 Thanks for the explanation @mfahimazizi. So, if you put the edge label inside the message that you send in the messaging function, then you will know which values to

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140895609 Fixed. Please let me know if I can merge this. Or should I wait for #1046 ? --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791134#comment-14791134 ] ASF GitHub Bot commented on FLINK-2566: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140898273 Tricky bug :-) If it does not depend on #1046, why not merge it? Or would you like to have somebody else looking over the code? --- If your project is set up

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791165#comment-14791165 ] ASF GitHub Bot commented on FLINK-2566: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140901138 #1046 seems to be almost done. Porting to the ExecutionConfig, shouldn't be too hard. I'd rather try to drive #1046 forward and merge it first, but it's up to you.

[GitHub] flink pull request: [FLINK-2357] Add the new web dashboard and mon...

2015-09-16 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1139 [FLINK-2357] Add the new web dashboard and monitoring REST API This pull request adds two new big features: The monitoring REST API and the web dashboard. It is joint work by @iampeter

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791124#comment-14791124 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on the pull request:

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140901671 Thanks. I agree with you. Just wanted to get a second opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791072#comment-14791072 ] ASF GitHub Bot commented on FLINK-2622: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140899681 I use the config that is introduced in #1046 already... See TODO in StormWrapperSetupHelper.java and StormWrapperSetupHelperTest.java ... Not sure if it is cleaver to

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791144#comment-14791144 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on the pull request:

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791168#comment-14791168 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on the pull request:

[jira] [Created] (FLINK-2691) Broken links to Python script on QuickStart doc

2015-09-16 Thread Felix Cheung (JIRA)
Felix Cheung created FLINK-2691: --- Summary: Broken links to Python script on QuickStart doc Key: FLINK-2691 URL: https://issues.apache.org/jira/browse/FLINK-2691 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-2691) Broken links to Python script on QuickStart doc

2015-09-16 Thread Felix Cheung (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Cheung updated FLINK-2691: Affects Version/s: 0.9 Component/s: Documentation > Broken links to Python script on

[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...

2015-09-16 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1131#issuecomment-140933982 Many thanks! This solved a big problem of mine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-16 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-140934136 Yes, I will take a fix for the comments:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-2691) Broken links to Python script on QuickStart doc

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791339#comment-14791339 ] ASF GitHub Bot commented on FLINK-2691: --- GitHub user felixcheung opened a pull request:

[GitHub] flink pull request: [FLINK-2691] fix broken links to Python script...

2015-09-16 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/flink/pull/1140 [FLINK-2691] fix broken links to Python script on QuickStart doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixcheung/flink

[jira] [Commented] (FLINK-2684) Make TypeInformation non-serializable again by removing Table API's need for it

2015-09-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790874#comment-14790874 ] Chesnay Schepler commented on FLINK-2684: - FLINK-2690 presents a possible use-case for

[jira] [Commented] (FLINK-2557) Manual type information via "returns" fails in DataSet API

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790756#comment-14790756 ] ASF GitHub Bot commented on FLINK-2557: --- Github user zentol commented on the pull request:

[GitHub] flink pull request: [FLINK-2557] TypeExtractor properly returns Mi...

2015-09-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1045#issuecomment-140810066 I've removed the refactoring commit and did a rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

<    1   2