[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-09 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1605#discussion_r52388115 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java --- @@ -0,0 +1,175 @@

[jira] [Commented] (FLINK-3335) Fix DataSourceTask object reuse when disabled

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139749#comment-15139749 ] ASF GitHub Bot commented on FLINK-3335: --- GitHub user greghogan opened a pull request:

[GitHub] flink pull request: [FLINK-3335] [runtime] Fix DataSourceTask obje...

2016-02-09 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1616 [FLINK-3335] [runtime] Fix DataSourceTask object reuse when disabled When object reuse is disabled, `DataSourceTask` now copies objects received from the `InputFormat` to prevent the collection

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139904#comment-15139904 ] ASF GitHub Bot commented on FLINK-2523: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139903#comment-15139903 ] ASF GitHub Bot commented on FLINK-2523: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139899#comment-15139899 ] ASF GitHub Bot commented on FLINK-2523: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1524#issuecomment-182066864 Setting the value to `fs.default-scheme: thisIsWrong:///` is good: ``` robert@cdh544-master:~/flink/build-target$ ./bin/flink run

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1524#issuecomment-182054657 I'm testing the change on a cluster (with YARN) to see if everything is working as expected. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52356401 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -102,60 +101,150 @@ //

[jira] [Commented] (FLINK-3333) Documentation about object reuse should be improved

2016-02-09 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139435#comment-15139435 ] Gabor Gevay commented on FLINK-: One more thing: if we decide to go with including chaining, then

[jira] [Closed] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper

2016-02-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-3382. - Resolution: Not A Problem Per the comment on the pull request, this change would interfere with proper

[jira] [Commented] (FLINK-3333) Documentation about object reuse should be improved

2016-02-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139668#comment-15139668 ] Greg Hogan commented on FLINK-: --- I can think of four return values from a user defined {{reduce()}}:

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

2016-02-09 Thread greghogan
Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/1614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3226] Translate logical aggregations to...

2016-02-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1600#discussion_r52349128 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala --- @@ -0,0 +1,145 @@ +/*

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139332#comment-15139332 ] ASF GitHub Bot commented on FLINK-3226: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Updated] (FLINK-3335) Fix DataSourceTask object reuse when disabled

2016-02-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-3335: -- Summary: Fix DataSourceTask object reuse when disabled (was: DataSourceTask object reuse when

[jira] [Updated] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper

2016-02-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-3382: -- Description: Object reuse in {{ReusingMutableToRegularIteratorWrapper.hasNext()}} can be clarified by

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139965#comment-15139965 ] ASF GitHub Bot commented on FLINK-2991: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1605#issuecomment-182125713 You are adding new `.apply()` variants to the API which are not documented with the PR. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52388927 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -102,60 +101,150 @@ //

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52388853 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -102,60 +101,150 @@ //

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139951#comment-15139951 ] ASF GitHub Bot commented on FLINK-2523: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139949#comment-15139949 ] ASF GitHub Bot commented on FLINK-2523: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139953#comment-15139953 ] ASF GitHub Bot commented on FLINK-2523: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52388350 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java --- @@ -141,9 +146,16 @@ public

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139942#comment-15139942 ] ASF GitHub Bot commented on FLINK-2523: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52388830 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -102,60 +101,150 @@ //

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-09 Thread sbcd90
GitHub user sbcd90 opened a pull request: https://github.com/apache/flink/pull/1617 [FLINK-3035] Redis as State Backend @mjsax please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sbcd90/flink FLINK-3035 Alternatively

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140206#comment-15140206 ] ASF GitHub Bot commented on FLINK-3035: --- GitHub user sbcd90 opened a pull request:

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-09 Thread Subhobrata Dey (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140239#comment-15140239 ] Subhobrata Dey commented on FLINK-3035: --- Hello [~mjsax] Thanks for replying. I adopted & created a

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-09 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1605#issuecomment-182237986 I'll add doc and also fix some other stuff in the doc that wasn't updated. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140460#comment-15140460 ] ASF GitHub Bot commented on FLINK-2991: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1612 FLINK-2523: Makes the task cancellation interval configurable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink

[GitHub] flink pull request: [FLINK-3260] [runtime] Enforce terminal state ...

2016-02-09 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/1613 [FLINK-3260] [runtime] Enforce terminal state of Executions This commit fixes the problem that Executions could leave their terminal state FINISHED to transition to FAILED. Such a

[jira] [Commented] (FLINK-3260) ExecutionGraph gets stuck in state FAILING

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139293#comment-15139293 ] ASF GitHub Bot commented on FLINK-3260: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request: [FLINK-3187] Introduce RestartStrategy to deco...

2016-02-09 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1470#issuecomment-181981959 If nobody objects, then I would like to merge this PR, since it will give us more flexibility in the future with respect to restarting strategies. --- If your

[jira] [Commented] (FLINK-3187) Decouple restart strategy from ExecutionGraph

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139297#comment-15139297 ] ASF GitHub Bot commented on FLINK-3187: --- Github user tillrohrmann commented on the pull request:

[jira] [Created] (FLINK-3383) Separate Maven deployment from CI testing

2016-02-09 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3383: - Summary: Separate Maven deployment from CI testing Key: FLINK-3383 URL: https://issues.apache.org/jira/browse/FLINK-3383 Project: Flink Issue

[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139279#comment-15139279 ] ASF GitHub Bot commented on FLINK-2523: --- GitHub user kl0u opened a pull request:

<    1   2   3