[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278777#comment-15278777 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/flink/pull/1958#issuecomment-218278581 Hi @fhueske, part of the comments are resolved and updated, two TODOs: - [ ] Type coercion for expressions, for example: - `Add(int, long)` should be auto

[jira] [Commented] (FLINK-3882) Errors in sample Java code for the Elasticsearch 2.x sink

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278822#comment-15278822 ] ASF GitHub Bot commented on FLINK-3882: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3821] Reduce Guava usage in flink-java

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1938 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3842) Fix handling null record/row in generated code

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278824#comment-15278824 ] ASF GitHub Bot commented on FLINK-3842: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3882][docs] Fix errors in sample Java c...

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1971 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62742390 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62742492 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278805#comment-15278805 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62745064 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/expression/ScalarFunctionsTest.scala --- @@ -215,7 +215,7 @@ class

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278792#comment-15278792 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on the pull request:

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278778#comment-15278778 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62731427 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/StreamTableEnvironment.scala --- @@ -92,8 +93,7 @@ abstract class

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278682#comment-15278682 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[jira] [Closed] (FLINK-3882) Errors in sample Java code for the Elasticsearch 2.x sink

2016-05-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3882. Resolution: Fixed Fix Version/s: 1.1.0 Fixed with 43bd6f6e4020d4102c34c5874ddfa850a281c8c8

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...

2016-05-10 Thread knaufk
GitHub user knaufk reopened a pull request: https://github.com/apache/flink/pull/1979 [FLINK-3758] Add possibility to register accumulators in custom triggers Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...

2016-05-10 Thread knaufk
Github user knaufk closed the pull request at: https://github.com/apache/flink/pull/1979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279033#comment-15279033 ] ASF GitHub Bot commented on FLINK-3758: --- Github user knaufk closed the pull request at:

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279035#comment-15279035 ] ASF GitHub Bot commented on FLINK-3758: --- GitHub user knaufk reopened a pull request:

[jira] [Closed] (FLINK-3842) Fix handling null record/row in generated code

2016-05-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3842. Resolution: Fixed Fix Version/s: 1.1.0 Fixed with 08e80546e20a24bdf204dec485d3ade83cf7804c

[GitHub] flink pull request: [Flink 3758] Add possibility to register accum...

2016-05-10 Thread knaufk
GitHub user knaufk opened a pull request: https://github.com/apache/flink/pull/1979 [Flink 3758] Add possibility to register accumulators in custom triggers 1 of 1 Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink pull request: [FLINK-3842] [table] Fix handling null record/...

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1974 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3821) Reduce Guava usage in flink-java

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278823#comment-15278823 ] ASF GitHub Bot commented on FLINK-3821: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-3821) Reduce Guava usage in flink-java

2016-05-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3821. Resolution: Implemented Implemented with 15f52112af1e3cca86094b5c6c1ef31157e073df > Reduce Guava

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

2016-05-10 Thread Mark Reddy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279155#comment-15279155 ] Mark Reddy commented on FLINK-3852: --- I can take this. One quick question after taking an initial look.

[GitHub] flink pull request: Build a flink-connector-kafka-0.9 test-jar

2016-05-10 Thread scosenza
Github user scosenza commented on the pull request: https://github.com/apache/flink/pull/1972#issuecomment-218318387 Hi Robert, Typically, a test-jar would not contain JUnit test classes unless they are designed to be extended. On a related note, it's also good to avoid

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

2016-05-10 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279399#comment-15279399 ] Tzu-Li (Gordon) Tai commented on FLINK-3852: Hi Mark, I think replacing the StreamingJob

[jira] [Issue Comment Deleted] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

2016-05-10 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-3852: --- Comment: was deleted (was: Hi Mark, I think replacing the StreamingJob skeleton as

[jira] [Created] (FLINK-3897) why does jobmanager process has too many ForkJoinTask object

2016-05-10 Thread ZhengBowen (JIRA)
ZhengBowen created FLINK-3897: - Summary: why does jobmanager process has too many ForkJoinTask object Key: FLINK-3897 URL: https://issues.apache.org/jira/browse/FLINK-3897 Project: Flink Issue

[jira] [Updated] (FLINK-3897) why does jobmanager process has too many ForkJoinTask object

2016-05-10 Thread ZhengBowen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhengBowen updated FLINK-3897: -- Description: jmap -histo 21415 |head -10 num #instances #bytes class name

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

2016-05-10 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279400#comment-15279400 ] Tzu-Li (Gordon) Tai commented on FLINK-3852: Hi Mark, I think replacing the StreamingJob

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-10 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1980 [FLINK-3780] [gelly] Jaccard Similarity The Jaccard Index measures the similarity between vertex neighborhoods. Scores range from 0.0 (no common neighbors) to 1.0 (all neighbors are common). You

[jira] [Commented] (FLINK-3780) Jaccard Similarity

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279511#comment-15279511 ] ASF GitHub Bot commented on FLINK-3780: --- GitHub user greghogan opened a pull request:

[jira] [Commented] (FLINK-3891) Add a class containing all supported Table API types

2016-05-10 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279438#comment-15279438 ] Yijie Shen commented on FLINK-3891: --- I think it will be great to implement this, looking forward the PR

[jira] [Created] (FLINK-3891) Add a class containing all supported Table API types

2016-05-10 Thread Timo Walther (JIRA)
Timo Walther created FLINK-3891: --- Summary: Add a class containing all supported Table API types Key: FLINK-3891 URL: https://issues.apache.org/jira/browse/FLINK-3891 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-3826) Broken test: StreamCheckpointingITCase

2016-05-10 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-3826: - Assignee: Kostas Kloudas > Broken test: StreamCheckpointingITCase >

[GitHub] flink pull request: [FLINK-3826] Broken test: StreamCheckpointingI...

2016-05-10 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1977 [FLINK-3826] Broken test: StreamCheckpointingITCase It uncomments the throw Exception, line 270. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...

2016-05-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1973#issuecomment-218142278 This is an API breaking change. Is there a way to overload the functions to make this non-API breaking? --- If your project is set up for it, you can

[jira] [Commented] (FLINK-3826) Broken test: StreamCheckpointingITCase

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278134#comment-15278134 ] ASF GitHub Bot commented on FLINK-3826: --- GitHub user kl0u opened a pull request:

[jira] [Commented] (FLINK-3869) WindowedStream.apply with FoldFunction is too restrictive

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278018#comment-15278018 ] ASF GitHub Bot commented on FLINK-3869: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-1502) Expose metrics to graphite, ganglia and JMX.

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278037#comment-15278037 ] ASF GitHub Bot commented on FLINK-1502: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-1502] [WIP] Basic Metric System

2016-05-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1947#issuecomment-218146940 Looks nice, I am trying it out now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-1502] [WIP] Basic Metric System

2016-05-10 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1947#issuecomment-218153465 I'm currently aware of the following issues: * quite a few tests in flink-runtime fail; this is mostly due to a missing integration into the MockEnvironments. Fix

[jira] [Commented] (FLINK-1502) Expose metrics to graphite, ganglia and JMX.

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278071#comment-15278071 ] ASF GitHub Bot commented on FLINK-1502: --- Github user zentol commented on the pull request:

[GitHub] flink pull request: [FLINK-3826] Broken test: StreamCheckpointingI...

2016-05-10 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1977#issuecomment-218167352 This is a fast one! Only one line. Please review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Created] (FLINK-3892) ConnectionUtils may die with NullPointerException

2016-05-10 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3892: - Summary: ConnectionUtils may die with NullPointerException Key: FLINK-3892 URL: https://issues.apache.org/jira/browse/FLINK-3892 Project: Flink

[jira] [Commented] (FLINK-3869) WindowedStream.apply with FoldFunction is too restrictive

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278031#comment-15278031 ] ASF GitHub Bot commented on FLINK-3869: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...

2016-05-10 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1973#issuecomment-218145066 I thought it wasn't breaking because it only changes the generic parameters. Any existing user code should still work as before. Or does the generics change break

[jira] [Commented] (FLINK-3826) Broken test: StreamCheckpointingITCase

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278135#comment-15278135 ] ASF GitHub Bot commented on FLINK-3826: --- Github user kl0u commented on the pull request:

[jira] [Created] (FLINK-3893) LeaderChangeStateCleanupTest times out

2016-05-10 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3893: - Summary: LeaderChangeStateCleanupTest times out Key: FLINK-3893 URL: https://issues.apache.org/jira/browse/FLINK-3893 Project: Flink Issue Type:

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278169#comment-15278169 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62682327 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/logic.scala --- @@ -21,25 +21,47 @@ import

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278183#comment-15278183 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62682619 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/mathExpressions.scala --- @@ -0,0 +1,147 @@ +/* + *

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62681558 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/arithmetic.scala --- @@ -25,15 +25,29 @@ import

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278188#comment-15278188 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278174#comment-15278174 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278172#comment-15278172 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3701] reuse serializer lists in Executi...

2016-05-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1913#discussion_r62684204 --- Diff: flink-core/src/main/java/org/apache/flink/util/SerializableCacheableValue.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62684054 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278195#comment-15278195 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62683416 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalNode.scala --- @@ -0,0 +1,169 @@ +/* + *

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278192#comment-15278192 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62685650 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/validate/exceptions.scala --- @@ -0,0 +1,20 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3826) Broken test: StreamCheckpointingITCase

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278261#comment-15278261 ] ASF GitHub Bot commented on FLINK-3826: --- Github user zentol commented on the pull request:

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62681024 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/Expression.scala --- @@ -17,13 +17,34 @@ */ package

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278164#comment-15278164 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62681920 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/arithmetic.scala --- @@ -25,15 +25,29 @@ import

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278185#comment-15278185 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278203#comment-15278203 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62684422 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62684793 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -472,61 +339,39 @@ class Table(

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278180#comment-15278180 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278212#comment-15278212 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62680102 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableEnvironment.scala --- @@ -197,6 +209,17 @@ abstract class

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278209#comment-15278209 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278154#comment-15278154 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62680699 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableEnvironment.scala --- @@ -152,13 +160,13 @@ abstract class

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62683621 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278198#comment-15278198 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62684644 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62683921 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3701) Cant call execute after first execution

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278197#comment-15278197 ] ASF GitHub Bot commented on FLINK-3701: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278199#comment-15278199 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62683790 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,309 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62685356 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/validate/FunctionCatalog.scala --- @@ -0,0 +1,159 @@ +/* + *

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278196#comment-15278196 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3701] reuse serializer lists in Executi...

2016-05-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1913#discussion_r62683914 --- Diff: flink-core/src/main/java/org/apache/flink/util/SerializableCacheableValue.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-3895) Remove Focs for Program Packaging via Plans

2016-05-10 Thread Ken Krugler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278231#comment-15278231 ] Ken Krugler commented on FLINK-3895: Maybe "Remove Docs for Program..."? :) > Remove Focs for

[GitHub] flink pull request: [FLINK-3826] Broken test: StreamCheckpointingI...

2016-05-10 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1977#issuecomment-218191358 @kl0u Could you stop posting a comment in every PR right after you opened it? You can add whatever you want to say to the main post. could we now remove the

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278160#comment-15278160 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62681359 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/aggregations.scala --- @@ -36,41 +39,59 @@ abstract sealed class

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62682155 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/fieldExpression.scala --- @@ -20,27 +20,98 @@ package

[jira] [Created] (FLINK-3894) Remove Program Packaging via Plans

2016-05-10 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-3894: --- Summary: Remove Program Packaging via Plans Key: FLINK-3894 URL: https://issues.apache.org/jira/browse/FLINK-3894 Project: Flink Issue Type: Improvement

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62682986 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalNode.scala --- @@ -0,0 +1,169 @@ +/* + *

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278187#comment-15278187 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[jira] [Created] (FLINK-3895) Remove Focs for Program Packaging via Plans

2016-05-10 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-3895: --- Summary: Remove Focs for Program Packaging via Plans Key: FLINK-3895 URL: https://issues.apache.org/jira/browse/FLINK-3895 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278181#comment-15278181 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62679391 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/StreamTableEnvironment.scala --- @@ -92,8 +93,7 @@ abstract class

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-05-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1958#discussion_r62683029 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalNode.scala --- @@ -0,0 +1,169 @@ +/* + *

  1   2   >