[jira] [Commented] (FLINK-5431) time format for akka status

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901362#comment-15901362 ] ASF GitHub Bot commented on FLINK-5431: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3297 Not sure about this. This seems to implement in Flink what is actually the responsibility of the logger. How about just updating the client such that there are two loggers configured:

[jira] [Commented] (FLINK-4754) Make number of retained checkpoints user configurable

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901360#comment-15901360 ] ASF GitHub Bot commented on FLINK-4754: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3374: [FLINK-4754] [checkpoints] Make number of retained checkp...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3374 Looks good in general. I would suggest two improvements: 1. Migrate the config parameter to `CoreOptions` 2. Add a test --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-08 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901356#comment-15901356 ] Ufuk Celebi commented on FLINK-5985: Is it possible to share the driver program (privately works as

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901344#comment-15901344 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901343#comment-15901343 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901342#comment-15901342 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901337#comment-15901337 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901345#comment-15901345 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901346#comment-15901346 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901339#comment-15901339 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901340#comment-15901340 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901341#comment-15901341 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901338#comment-15901338 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901347#comment-15901347 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104922022 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggFlatMapFunction.scala --- @@ -0,0

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104919295 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala --- @@ -312,6 +320,108 @@ class

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104925837 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -186,6 +200,130 @@ object

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104925916 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -186,6 +200,130 @@ object

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104925507 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -186,6 +200,130 @@ object

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104927549 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/IncrementalAggregateAllWindowFunction.scala --- @@ -53,7

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104926612 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggReduceCombineFunction.scala --- @@

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104921975 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggFlatMapFunction.scala --- @@ -0,0

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104925166 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggFlatMapFunction.scala --- @@ -0,0

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104922073 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggFlatMapFunction.scala --- @@ -0,0

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104927085 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetTumbleTimeWindowAggReduceGroupFunction.scala --- @@

[jira] [Commented] (FLINK-3427) Add watermark monitoring to JobManager web frontend

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901336#comment-15901336 ] ASF GitHub Bot commented on FLINK-3427: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3366 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2017-03-08 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901331#comment-15901331 ] Wei-Che Wei commented on FLINK-5982: [~StephanEwen], [~till.rohrmann] Have updated the description. Is

[jira] [Created] (FLINK-5999) MiniClusterITCase.runJobWithMultipleRpcServices fails

2017-03-08 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5999: -- Summary: MiniClusterITCase.runJobWithMultipleRpcServices fails Key: FLINK-5999 URL: https://issues.apache.org/jira/browse/FLINK-5999 Project: Flink Issue Type:

[jira] [Commented] (FLINK-5999) MiniClusterITCase.runJobWithMultipleRpcServices fails

2017-03-08 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901330#comment-15901330 ] Ufuk Celebi commented on FLINK-5999:

[jira] [Commented] (FLINK-1725) New Partitioner for better load balancing for skewed data

2017-03-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901317#comment-15901317 ] Stephan Ewen commented on FLINK-1725: - [~aadi.anis] I hope you understand this decision - this would

[jira] [Commented] (FLINK-1725) New Partitioner for better load balancing for skewed data

2017-03-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901314#comment-15901314 ] Stephan Ewen commented on FLINK-1725: - Closing this issue with "later". Please re-open if you have

[jira] [Commented] (FLINK-5994) Add Janino to flink-table JAR file

2017-03-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901320#comment-15901320 ] sunjincheng commented on FLINK-5994: Thanks [~twalthr], I'll look at the ML, and work on this. > Add

[jira] [Updated] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2017-03-08 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Che Wei updated FLINK-5982: --- Description: Currently, running a invokable in {{Task}} needs to call {{setEnvironment(env)}} and

[jira] [Assigned] (FLINK-5994) Add Janino to flink-table JAR file

2017-03-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reassigned FLINK-5994: -- Assignee: sunjincheng > Add Janino to flink-table JAR file >

[jira] [Closed] (FLINK-1725) New Partitioner for better load balancing for skewed data

2017-03-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-1725. --- > New Partitioner for better load balancing for skewed data >

[jira] [Resolved] (FLINK-1725) New Partitioner for better load balancing for skewed data

2017-03-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1725. - Resolution: Later > New Partitioner for better load balancing for skewed data >

[jira] [Commented] (FLINK-1725) New Partitioner for better load balancing for skewed data

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901312#comment-15901312 ] ASF GitHub Bot commented on FLINK-1725: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #1069: [FLINK-1725]- New Partitioner for better load balancing f...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/1069 Can we close this pull request and revisit the feature later? The partial grouping does currently not work for windows, rescaling, etc, and it would be quite involved to add this. --- If

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2017-03-08 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901309#comment-15901309 ] Wei-Che Wei commented on FLINK-5982: If handling recovery state on {{BatchTask}} is needed in the

[jira] [Created] (FLINK-5998) Un-fat Hadoop from Flink fat jar

2017-03-08 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-5998: - Summary: Un-fat Hadoop from Flink fat jar Key: FLINK-5998 URL: https://issues.apache.org/jira/browse/FLINK-5998 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-5668) passing taskmanager configuration through taskManagerEnv instead of file

2017-03-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901304#comment-15901304 ] Stephan Ewen commented on FLINK-5668: - Here is a pull request for (1)

[jira] [Updated] (FLINK-2268) Provide Flink binary release without Hadoop

2017-03-08 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-2268: -- Description: Currently, all Flink releases ship with Hadoop 2.3.0 binaries. The big Hadoop

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2017-03-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901289#comment-15901289 ] Stephan Ewen commented on FLINK-5982: - I am personally for dropping the distinction between

[jira] [Commented] (FLINK-5668) passing taskmanager configuration through taskManagerEnv instead of file

2017-03-08 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901284#comment-15901284 ] Stephan Ewen commented on FLINK-5668: - Some background from the Flink side: - There is quite a bit

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901283#comment-15901283 ] ASF GitHub Bot commented on FLINK-4714: --- Github user tony810430 commented on the issue:

[jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901282#comment-15901282 ] ASF GitHub Bot commented on FLINK-5778: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3442: [FLINK-5778] [savepoints] Add savepoint serializer with r...

2017-03-08 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3442 Very much ok with me, my vote on this was actually on keeping old versioned code duplicated and immutable. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #3474: [FLINK-4714] [runtime] [streaming] Set task state to RUNN...

2017-03-08 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3474 @StephanEwen BTW, I have opened a JIRA task for refactoring `AbstractInvokable` and `StatefulTask`. How about discussing this topic in

[jira] [Commented] (FLINK-5635) Improve Docker tooling to make it easier to build images and launch Flink via Docker tools

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901276#comment-15901276 ] ASF GitHub Bot commented on FLINK-5635: --- Github user iemejia commented on a diff in the pull

[jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901273#comment-15901273 ] ASF GitHub Bot commented on FLINK-5778: --- Github user uce commented on the issue:

[GitHub] flink pull request #3494: [FLINK-5635] [docker] Improve Docker tooling

2017-03-08 Thread iemejia
Github user iemejia commented on a diff in the pull request: https://github.com/apache/flink/pull/3494#discussion_r104919360 --- Diff: flink-contrib/docker-flink/Dockerfile --- @@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin EXPOSE 8081 EXPOSE 6123 +#

[GitHub] flink issue #3442: [FLINK-5778] [savepoints] Add savepoint serializer with r...

2017-03-08 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3442 I agree with the equals/hashCode question. It has been introduced for the various involved classes by different people and not in this PR, so I think it's best handled as part of a different issue.

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901260#comment-15901260 ] ASF GitHub Bot commented on FLINK-4714: --- Github user tony810430 commented on the issue:

[GitHub] flink issue #3474: [FLINK-4714] [runtime] [streaming] Set task state to RUNN...

2017-03-08 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3474 @StephanEwen How about using `AbstractInvokable.class.isAssignableFrom()` and `StatefulTask.class.isAssignableFrom()` to check the loaded class? Then, we can check if the

[jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901258#comment-15901258 ] ASF GitHub Bot commented on FLINK-5778: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3442: [FLINK-5778] [savepoints] Add savepoint serializer with r...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3442 Another thought from the discussion with @StefanRRichter : You refactor a lot to not have duplicate code. While this is good in general, I am wondering if we should not actually duplicate the

[jira] [Commented] (FLINK-5909) Interface for GraphAlgorithm results

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901251#comment-15901251 ] ASF GitHub Bot commented on FLINK-5909: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3434: [FLINK-5909] [gelly] Interface for GraphAlgorithm results

2017-03-08 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3434 @vasia, I created `PrintableResult` with a `toPrintableString` method and is now used for both algorithms and analytics. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-5994) Add Janino to flink-table JAR file

2017-03-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901250#comment-15901250 ] Timo Walther commented on FLINK-5994: - Yes, of course. Thanks. This the related mail from the ML:

[jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901247#comment-15901247 ] ASF GitHub Bot commented on FLINK-5778: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3442: [FLINK-5778] [savepoints] Add savepoint serializer with r...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3442 Looks good in general. One thing that I stumbled across a lot in recent works on the checkpoints / savepoints is that they all implement `equals` and `hashCode` and delegate to the task

[GitHub] flink issue #3485: FLINK-5976 [tests] Deduplicate Tokenizer in tests

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3485 Would be nice to follow up here and collect also functions like "identity mapper" or so in that package. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-5598) Return jar name when jar is uploaded

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901241#comment-15901241 ] ASF GitHub Bot commented on FLINK-5598: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3469: [FLINK-5598] return filename after jar upload

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3469 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901240#comment-15901240 ] ASF GitHub Bot commented on FLINK-4714: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3474: [FLINK-4714] [runtime] [streaming] Set task state to RUNN...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3474 @tony810430 I think we can drop the interface `StatefulTask` and just assume every task is stateful. The `BatchTask` can throw an error, if it gets a non-null value for the state in the

[GitHub] flink issue #3487: [FLINK-5980] Expose max-parallelism value in RuntimeConte...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3487 For batch jobs, I would suggest that we make sure that the `ExecutionEnvironment` or the `JobGraphGenerator` sets the max parallelism to the parallelism. Then we do not need to differentiate in

[jira] [Commented] (FLINK-5976) Refactoring duplicate Tokenizer in flink-test

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901227#comment-15901227 ] ASF GitHub Bot commented on FLINK-5976: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5976) Refactoring duplicate Tokenizer in flink-test

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901228#comment-15901228 ] ASF GitHub Bot commented on FLINK-5976: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3485: FLINK-5976 [tests] Deduplicate Tokenizer in tests

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3485 How about we create a package `org.apache.flink.test.testfunctions` where we collect all shared reusable function implementations? --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-5994) Add Janino to flink-table JAR file

2017-03-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901226#comment-15901226 ] sunjincheng commented on FLINK-5994: Hi,[~twalthr], I glad to do this issue. Can I take this JIRA.? >

[GitHub] flink pull request #3494: [FLINK-5635] [docker] Improve Docker tooling

2017-03-08 Thread patricklucas
Github user patricklucas commented on a diff in the pull request: https://github.com/apache/flink/pull/3494#discussion_r104912987 --- Diff: flink-contrib/docker-flink/Dockerfile --- @@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin EXPOSE 8081 EXPOSE 6123 +#

[jira] [Commented] (FLINK-5980) Expose max-parallelism value in RuntimeContext

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901225#comment-15901225 ] ASF GitHub Bot commented on FLINK-5980: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5722) Implement DISTINCT as dedicated operator

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901223#comment-15901223 ] ASF GitHub Bot commented on FLINK-5722: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct...

2017-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (FLINK-5722) Implement DISTINCT as dedicated operator

2017-03-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-5722. - Resolution: Fixed Fix Version/s: 1.3.0 Fixed in 1.3.0:

[jira] [Commented] (FLINK-5635) Improve Docker tooling to make it easier to build images and launch Flink via Docker tools

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901216#comment-15901216 ] ASF GitHub Bot commented on FLINK-5635: --- Github user patricklucas commented on a diff in the pull

[jira] [Commented] (FLINK-5722) Implement DISTINCT as dedicated operator

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901215#comment-15901215 ] ASF GitHub Bot commented on FLINK-5722: --- Github user twalthr commented on the issue:

[GitHub] flink issue #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct operat...

2017-03-08 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3471 Thanks @fhueske. LGTM, merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901200#comment-15901200 ] ASF GitHub Bot commented on FLINK-5047: --- Github user twalthr commented on the issue:

[GitHub] flink issue #3364: [FLINK-5047] [table] Add sliding group-windows for batch ...

2017-03-08 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3364 Thanks for the feedback @fhueske. I updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Assigned] (FLINK-5984) Allow reusing of accumulators in AggregateFunction

2017-03-08 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-5984: Assignee: Shaoxuan Wang > Allow reusing of accumulators in AggregateFunction >

[jira] [Commented] (FLINK-5635) Improve Docker tooling to make it easier to build images and launch Flink via Docker tools

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901182#comment-15901182 ] ASF GitHub Bot commented on FLINK-5635: --- Github user iemejia commented on a diff in the pull

[GitHub] flink pull request #3494: [FLINK-5635] [docker] Improve Docker tooling

2017-03-08 Thread iemejia
Github user iemejia commented on a diff in the pull request: https://github.com/apache/flink/pull/3494#discussion_r104907373 --- Diff: flink-contrib/docker-flink/Dockerfile --- @@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin EXPOSE 8081 EXPOSE 6123 +#

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901120#comment-15901120 ] ASF GitHub Bot commented on FLINK-3026: --- Github user patricklucas commented on the issue:

[jira] [Updated] (FLINK-5997) Docker build tools should inline GPG key to verify HTTP Flink release download

2017-03-08 Thread Patrick Lucas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Lucas updated FLINK-5997: - Description: See examples

[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...

2017-03-08 Thread patricklucas
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3493 Aha, I see. I didn't follow the chain up further. :) Then yes, I'm generally on board with following this convention. --- If your project is set up for it, you can reply to this email

[jira] [Created] (FLINK-5997) Docker build tools should inline GPG key to verify HTTP Flink release download

2017-03-08 Thread Patrick Lucas (JIRA)
Patrick Lucas created FLINK-5997: Summary: Docker build tools should inline GPG key to verify HTTP Flink release download Key: FLINK-5997 URL: https://issues.apache.org/jira/browse/FLINK-5997

[jira] [Commented] (FLINK-5996) Jobmanager HA should not crash on lost ZK node

2017-03-08 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901108#comment-15901108 ] Gyula Fora commented on FLINK-5996: --- That is correct. The jobmanager fails and recovers successfully but

[GitHub] flink issue #3494: [FLINK-5635] [docker] Improve Docker tooling

2017-03-08 Thread patricklucas
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3494 cc @ex00 @tonycox @iemejia --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-5635) Improve Docker tooling to make it easier to build images and launch Flink via Docker tools

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901106#comment-15901106 ] ASF GitHub Bot commented on FLINK-5635: --- Github user patricklucas commented on the issue:

[jira] [Commented] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-08 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901105#comment-15901105 ] Gyula Fora commented on FLINK-5985: --- Hi Ufuk, I did exactly this yesterday: First got an error like:

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901102#comment-15901102 ] ASF GitHub Bot commented on FLINK-3026: --- Github user iemejia commented on the issue:

[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...

2017-03-08 Thread iemejia
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3493 Yes, maybe I was not clear enough, my goal is to support the two variants of openjdk that you mention. I was just mentioning ubuntu/debian because this is the base of the non-alpine base

[jira] [Commented] (FLINK-5980) Expose max-parallelism value in RuntimeContext

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901101#comment-15901101 ] ASF GitHub Bot commented on FLINK-5980: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3487: [FLINK-5980] Expose max-parallelism value in Runti...

2017-03-08 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3487#discussion_r104896041 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java --- @@ -97,10 +97,16 @@ public int

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901099#comment-15901099 ] ASF GitHub Bot commented on FLINK-3026: --- Github user patricklucas commented on the issue:

<    1   2   3   4   >