[jira] [Commented] (FLINK-6007) ConcurrentModificationException in WatermarkCallbackService

2017-03-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903254#comment-15903254 ] Aljoscha Krettek commented on FLINK-6007: - Or we could duplicate the set of keys before iterating.

[jira] [Created] (FLINK-6007) ConcurrentModificationException in WatermarkCallbackService

2017-03-09 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-6007: - Summary: ConcurrentModificationException in WatermarkCallbackService Key: FLINK-6007 URL: https://issues.apache.org/jira/browse/FLINK-6007 Project: Flink

[jira] [Commented] (FLINK-6007) ConcurrentModificationException in WatermarkCallbackService

2017-03-09 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903293#comment-15903293 ] Kostas Kloudas commented on FLINK-6007: --- [~aljoscha] Now that I come to think about it, this

[GitHub] flink issue #3386: [FLINK-5658][table] support unbounded eventtime over wind...

2017-03-09 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3386 Hi, @hongyuhong Thanks for updated the PR. I'll fast pass over the changes, and leave feedback for you. Best, SunJIncheng --- If your project is set up for it, you can reply to this

[GitHub] flink issue #3431: [FLINK-5910] [gelly] Framework for Gelly examples

2017-03-09 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3431 @vasia, I was only thinking of this being used in gelly examples. The documentation for the use of the example drivers will be updated but I am anticipating that users will enclose new and

[jira] [Commented] (FLINK-5910) Framework for Gelly examples

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903344#comment-15903344 ] ASF GitHub Bot commented on FLINK-5910: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903423#comment-15903423 ] ASF GitHub Bot commented on FLINK-5874: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3501 [FLINK-5874] Restrict key types in the DataStream API. Rejects a type from being a key in `DataStream.keyBy()` if it is: 1. it is a POJO type but does not override the `hashCode()` and

[jira] [Closed] (FLINK-5909) Interface for GraphAlgorithm results

2017-03-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-5909. - Resolution: Implemented Implemented in 33cd97953a7943437acb925ad3296a1eb9858c73 > Interface for

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-09 Thread Patrick Lucas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903317#comment-15903317 ] Patrick Lucas commented on FLINK-3026: -- Yes, I gave you contributor permissions. This repo is really

[jira] [Updated] (FLINK-6007) ConcurrentModificationException in WatermarkCallbackService

2017-03-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-6007: Priority: Blocker (was: Major) > ConcurrentModificationException in

[jira] [Commented] (FLINK-5804) Add [non-partitioned] processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903325#comment-15903325 ] ASF GitHub Bot commented on FLINK-5804: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-6003) Add docker image based on the openjdk one (debian+alpine)

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903383#comment-15903383 ] ASF GitHub Bot commented on FLINK-6003: --- Github user iemejia commented on the issue:

[GitHub] flink issue #3500: [FLINK-6003] Add docker image based on the openjdk one (d...

2017-03-09 Thread iemejia
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3500 Hey I probably should be more patient, I will wait until #3494 is merged and rebase from it. So closing for the moment. --- If your project is set up for it, you can reply to this email and have

[jira] [Created] (FLINK-6008) collection of BlobServer improvements

2017-03-09 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-6008: -- Summary: collection of BlobServer improvements Key: FLINK-6008 URL: https://issues.apache.org/jira/browse/FLINK-6008 Project: Flink Issue Type: Improvement

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-09 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r105187427 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -139,9 +143,35 @@ object

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903202#comment-15903202 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on the issue:

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-09 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903272#comment-15903272 ] Ismaël Mejía commented on FLINK-3026: - Great, taking a look right now, I will rebase my PR adding the

[jira] [Comment Edited] (FLINK-6007) ConcurrentModificationException in WatermarkCallbackService

2017-03-09 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903269#comment-15903269 ] Kostas Kloudas edited comment on FLINK-6007 at 3/9/17 4:04 PM: --- True. This

[GitHub] flink issue #3491: [FLINK-5804] [table] Add support for procTime non-partiti...

2017-03-09 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3491 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-09 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r105186593 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -139,9 +143,35 @@ object

[jira] [Commented] (FLINK-6007) ConcurrentModificationException in WatermarkCallbackService

2017-03-09 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903269#comment-15903269 ] Kostas Kloudas commented on FLINK-6007: --- True. This way we do not have to checkpoint the

[jira] [Commented] (FLINK-6003) Add docker image based on the openjdk one (debian+alpine)

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903384#comment-15903384 ] ASF GitHub Bot commented on FLINK-6003: --- Github user iemejia closed the pull request at:

[GitHub] flink pull request #3500: [FLINK-6003] Add docker image based on the openjdk...

2017-03-09 Thread iemejia
Github user iemejia closed the pull request at: https://github.com/apache/flink/pull/3500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904650#comment-15904650 ] ASF GitHub Bot commented on FLINK-4565: --- Github user DmytroShkvyra closed the pull request at:

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904651#comment-15904651 ] ASF GitHub Bot commented on FLINK-4565: --- GitHub user DmytroShkvyra reopened a pull request:

[GitHub] flink pull request #3504: [FLINK-6010] Documentation: correct IntelliJ IDEA ...

2017-03-09 Thread phoenixjiangnan
GitHub user phoenixjiangnan opened a pull request: https://github.com/apache/flink/pull/3504 [FLINK-6010] Documentation: correct IntelliJ IDEA Plugins path in 'In… …stalling the Scala plugin' section You can merge this pull request into a Git repository by running: $ git

[jira] [Commented] (FLINK-6010) Documentation: correct IntelliJ IDEA Plugins path in 'Installing the Scala plugin' section

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904413#comment-15904413 ] ASF GitHub Bot commented on FLINK-6010: --- GitHub user phoenixjiangnan opened a pull request:

[jira] [Created] (FLINK-6017) CSV reader does not support quoted double quotes

2017-03-09 Thread Luke Hutchison (JIRA)
Luke Hutchison created FLINK-6017: - Summary: CSV reader does not support quoted double quotes Key: FLINK-6017 URL: https://issues.apache.org/jira/browse/FLINK-6017 Project: Flink Issue Type:

[jira] [Created] (FLINK-6018) Minor improvements about `AbstractKeyedStateBackend#getPartitionedState` method

2017-03-09 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6018: -- Summary: Minor improvements about `AbstractKeyedStateBackend#getPartitionedState` method Key: FLINK-6018 URL: https://issues.apache.org/jira/browse/FLINK-6018 Project:

[jira] [Updated] (FLINK-6018) Minor improvements about `AbstractKeyedStateBackend#getPartitionedState` method

2017-03-09 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6018: --- Description: The code snippet currently in the `AbstractKeyedStateBackend # getPartitionedState`

[jira] [Updated] (FLINK-6018) Minor improvements about `AbstractKeyedStateBackend#getPartitionedState` method

2017-03-09 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6018: --- Description: The code snippet currently in the `AbstractKeyedStateBackend # getPartitionedState`

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105158798 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala --- @@ -68,6 +64,87 @@ object CommonTestData {

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105142163 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala --- @@ -0,0 +1,164 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105138498 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogDatabase.scala --- @@ -0,0 +1,29 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105137846 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105138652 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala --- @@ -0,0 +1,73 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105121440 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105141318 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105179034 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java --- @@ -0,0 +1,63 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105136850 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105124247 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105159600 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalCatalogSchemaTest.scala --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105141370 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105159735 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalCatalogSchemaTest.scala --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105137565 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105141214 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala --- @@ -0,0 +1,164 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105141923 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105138128 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-09 Thread Patrick Lucas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903162#comment-15903162 ] Patrick Lucas commented on FLINK-3026: -- The new

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-09 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903128#comment-15903128 ] Ismaël Mejía commented on FLINK-3026: - I wonder still how could we address the issue of community

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-09 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903127#comment-15903127 ] Ismaël Mejía commented on FLINK-3026: - I suppose most projects do this to avoid having a plethora of

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105138617 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala --- @@ -0,0 +1,73 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r105140265 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903159#comment-15903159 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on the issue:

[GitHub] flink issue #3480: [FLINK-4545] use size-restricted LocalBufferPool instance...

2017-03-09 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3480 added the requested changes and successfully rebased on the newest master due to conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-09 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r105182198 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/utils/UserDefinedScalarFunctions.scala --- @@ -221,3 +223,18 @@

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903164#comment-15903164 ] ASF GitHub Bot commented on FLINK-5881: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903546#comment-15903546 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on the issue:

[GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator

2017-03-09 Thread DmytroShkvyra
Github user DmytroShkvyra commented on a diff in the pull request: https://github.com/apache/flink/pull/2870#discussion_r105241841 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -150,7 +150,35 @@ class Table( * }}}

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903561#comment-15903561 ] ASF GitHub Bot commented on FLINK-4460: --- Github user chenqin commented on a diff in the pull

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-09 Thread chenqin
Github user chenqin commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105235710 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -419,6 +435,14 @@ public

[jira] [Commented] (FLINK-5838) Print shell script usage

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903509#comment-15903509 ] ASF GitHub Bot commented on FLINK-5838: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-5838) Print shell script usage

2017-03-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-5838. - Resolution: Fixed Fixed in 3fcc4e37c282a07e09c19934e71c141beefd8073 > Print shell script usage >

[GitHub] flink pull request #3491: [FLINK-5804] [table] Add support for procTime non-...

2017-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3402: [FLINK-5890] [gelly] GatherSumApply broken when object re...

2017-03-09 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3402 @StephanEwen, I updated the test to include the original test plus a new test with object reuse enabled. @vasia, would you be also be able to review this change? --- If your project is

[GitHub] flink issue #3389: [FLINK-5881] [table] ScalarFunction(UDF) should support v...

2017-03-09 Thread clarkyzl
Github user clarkyzl commented on the issue: https://github.com/apache/flink/pull/3389 Hi @twalthr . I've updated the patch as your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903615#comment-15903615 ] ASF GitHub Bot commented on FLINK-4565: --- Github user DmytroShkvyra commented on a diff in the pull

[GitHub] flink issue #3501: [FLINK-5874] Restrict key types in the DataStream API.

2017-03-09 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3501 This should work and is well tested, good job. Had a bunch of minor comments, but nothing critical. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903645#comment-15903645 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903654#comment-15903654 ] ASF GitHub Bot commented on FLINK-4565: --- Github user DmytroShkvyra commented on a diff in the pull

[GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator

2017-03-09 Thread DmytroShkvyra
Github user DmytroShkvyra commented on a diff in the pull request: https://github.com/apache/flink/pull/2870#discussion_r105244663 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala --- @@ -1101,6 +1101,45 @@

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903759#comment-15903759 ] ASF GitHub Bot commented on FLINK-4565: --- GitHub user DmytroShkvyra opened a pull request:

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105225561 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -419,6 +435,14 @@ public void

[GitHub] flink pull request #3352: [FLINK-5838] [scripts] Print shell script usage

2017-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903586#comment-15903586 ] ASF GitHub Bot commented on FLINK-4565: --- Github user DmytroShkvyra commented on a diff in the pull

[GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator

2017-03-09 Thread DmytroShkvyra
Github user DmytroShkvyra commented on a diff in the pull request: https://github.com/apache/flink/pull/2870#discussion_r105238764 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -870,6 +870,16 @@ class

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105242176 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors()

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105241450 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors()

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105239060 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors()

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105239799 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -114,9 +121,53 @@ public

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105240936 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors()

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105240820 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -114,9 +121,53 @@ public

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105239223 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java --- @@ -736,7 +736,7 @@ public void restoreState(List state)

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105241140 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors()

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105240510 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -114,9 +121,53 @@ public

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105240608 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -114,9 +121,53 @@ public

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105241562 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors()

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903460#comment-15903460 ] ASF GitHub Bot commented on FLINK-4460: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-5890) GatherSumApply broken when object reuse enabled

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903529#comment-15903529 ] ASF GitHub Bot commented on FLINK-5890: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-5804) Add [non-partitioned] processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903527#comment-15903527 ] ASF GitHub Bot commented on FLINK-5804: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-5804) Add [non-partitioned] processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-5804. Resolution: Implemented Fix Version/s: 1.3.0 Implemented with

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903637#comment-15903637 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903631#comment-15903631 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903635#comment-15903635 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903628#comment-15903628 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903633#comment-15903633 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903638#comment-15903638 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903634#comment-15903634 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903630#comment-15903630 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

  1   2   3   >