[jira] [Closed] (FLINK-6195) Move gelly-examples jar from opt to examples

2017-04-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-6195. - Resolution: Implemented Implemented in 568e64282eaa2671b4e46655e1fa773f9bb1e492 > Move gelly-examples jar

[jira] [Commented] (FLINK-6195) Move gelly-examples jar from opt to examples

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972828#comment-15972828 ] ASF GitHub Bot commented on FLINK-6195: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972829#comment-15972829 ] ASF GitHub Bot commented on FLINK-6300: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3691: [FLINK-6195] [build] Move gelly-examples jar from ...

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6307) Refactor JDBC tests

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972814#comment-15972814 ] ASF GitHub Bot commented on FLINK-6307: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #3723: [FLINK-6307] [jdbc] Refactor JDBC tests

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3723#discussion_r111971942 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -272,63 +209,61 @@ public void testJDB

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972803#comment-15972803 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111969982 --- Diff: docs/setup/config.md --- @@ -602,26 +612,66 @@ You have to configure `jobmanager.archive.fs.dir` in order to archive terminated ## Backgro

[jira] [Commented] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-04-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972787#comment-15972787 ] Aljoscha Krettek commented on FLINK-6294: - Yes, it can only happen if not properly

[jira] [Closed] (FLINK-6283) Enable to clear a given file cache path

2017-04-18 Thread Zohar Mizrahi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zohar Mizrahi closed FLINK-6283. Resolution: Won't Do > Enable to clear a given file cache path > --

[jira] [Commented] (FLINK-6283) Enable to clear a given file cache path

2017-04-18 Thread Zohar Mizrahi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972776#comment-15972776 ] Zohar Mizrahi commented on FLINK-6283: -- Yes, this is how I implemented it. In additio

[jira] [Commented] (FLINK-6319) Add timeout when shutting SystemProcessingTimeService down

2017-04-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972775#comment-15972775 ] Aljoscha Krettek commented on FLINK-6319: - I think [~StephanEwen] had some thought

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972771#comment-15972771 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in t

[jira] [Comment Edited] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-18 Thread Stefano Bortoli (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972574#comment-15972574 ] Stefano Bortoli edited comment on FLINK-6250 at 4/18/17 2:22 PM: ---

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111966911 --- Diff: docs/setup/config.md --- @@ -602,26 +612,66 @@ You have to configure `jobmanager.archive.fs.dir` in order to archive terminated ## Backgr

[jira] [Commented] (FLINK-6307) Refactor JDBC tests

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972759#comment-15972759 ] ASF GitHub Bot commented on FLINK-6307: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #3723: [FLINK-6307] [jdbc] Refactor JDBC tests

2017-04-18 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3723#discussion_r111966195 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -272,63 +209,61 @@ public void testJ

[jira] [Commented] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-04-18 Thread Andrey (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972752#comment-15972752 ] Andrey commented on FLINK-6294: --- I have the same version. Maybe this issue happens when Buck

[jira] [Commented] (FLINK-4973) Flakey Yarn tests due to recently added latency marker

2017-04-18 Thread Andrey (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972750#comment-15972750 ] Andrey commented on FLINK-4973: --- Proper handling InterruptedException will make it possible

[jira] [Comment Edited] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972736#comment-15972736 ] mingleizhang edited comment on FLINK-6130 at 4/18/17 2:10 PM: --

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972745#comment-15972745 ] ASF GitHub Bot commented on FLINK-6149: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3594 Hi @KurtYoung, thanks for the update! I think this PR is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Updated] (FLINK-6321) RocksDB state backend Checkpointing is not working with KeydCEP.

2017-04-18 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashank Agarwal updated FLINK-6321: Description: Checkpointing is not working with RocksDBStateBackend when using CEP. It's wor

[jira] [Commented] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-04-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972741#comment-15972741 ] Aljoscha Krettek commented on FLINK-6294: - I created a test job that uses {{Bucket

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972736#comment-15972736 ] mingleizhang commented on FLINK-6130: - [~till.rohrmann] Void ? I see. I would think {c

[jira] [Updated] (FLINK-6321) RocksDB state backend Checkpointing is not working with KeydCEP.

2017-04-18 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashank Agarwal updated FLINK-6321: Description: Checkpointing is not working with RocksDBStateBackend when using CEP. It's wor

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972731#comment-15972731 ] Chesnay Schepler commented on FLINK-6130: - [~mingleizhang] No, it is of type Futur

[jira] [Created] (FLINK-6321) RocksDB state backend Checkpointing is not working with KeydCEP.

2017-04-18 Thread Shashank Agarwal (JIRA)
Shashank Agarwal created FLINK-6321: --- Summary: RocksDB state backend Checkpointing is not working with KeydCEP. Key: FLINK-6321 URL: https://issues.apache.org/jira/browse/FLINK-6321 Project: Flink

[jira] [Commented] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972727#comment-15972727 ] ASF GitHub Bot commented on FLINK-6300: --- Github user patricklucas commented on the i

[GitHub] flink issue #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread patricklucas
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3734 Great, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972723#comment-15972723 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972714#comment-15972714 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972719#comment-15972719 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972717#comment-15972717 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972716#comment-15972716 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972711#comment-15972711 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972715#comment-15972715 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972712#comment-15972712 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972726#comment-15972726 ] ASF GitHub Bot commented on FLINK-6300: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972720#comment-15972720 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972721#comment-15972721 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972724#comment-15972724 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972713#comment-15972713 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972718#comment-15972718 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[jira] [Commented] (FLINK-6091) Implement and turn on the retraction for aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972722#comment-15972722 ] ASF GitHub Bot commented on FLINK-6091: --- Github user lincoln-lil commented on a diff

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111957849 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java --- @@ -198,6 +209,7 @@ public Row deserialize(Row reu

[GitHub] flink issue #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3734 @patricklucas yes, had just come back to say that :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111957675 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java --- @@ -40,6 +42,7 @@ private static final lon

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111957812 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java --- @@ -171,6 +181,7 @@ public Row deserialize(DataInp

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111959451 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala --- @@ -68,12 +70,35 @@ clas

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111959829 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/RetractionITCase.scala --- @@ -0,0 +1,310 @@ +/* +

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111958057 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -46,6 +46,9 @@ /** The array to store actual values. */ private

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111958631 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala --- @@ -182,9 +192,17 @@ trait CommonCorrel

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111958339 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala --- @@ -52,10 +53,18 @@ trait CommonCalc {

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111958512 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala --- @@ -135,11 +136,20 @@ trait CommonCorre

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111958225 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -46,6 +46,9 @@ /** The array to store actual values. */ private

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111957949 --- Diff: flink-core/src/main/java/org/apache/flink/types/Command.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111959008 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala --- @@ -107,6 +10

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111959203 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -129,11 +131,17 @

[GitHub] flink pull request #3733: [FLINK-6091] [table] Implement and turn on retract...

2017-04-18 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3733#discussion_r111959594 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala --- @@ -84,16 +109,38 @@ cla

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972709#comment-15972709 ] Till Rohrmann commented on FLINK-6130: -- [~Zentol] maybe the {{@GuardedBy("lock)}} ann

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972698#comment-15972698 ] ASF GitHub Bot commented on FLINK-6242: --- GitHub user shaoxuan-wang opened a pull req

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3735 [FLINK-6242] [table] Add code generation for DataSet Aggregates Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into considerat

[jira] [Commented] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972696#comment-15972696 ] ASF GitHub Bot commented on FLINK-6300: --- Github user patricklucas commented on the i

[GitHub] flink issue #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread patricklucas
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3734 @greghogan do you think you could merge this? (also to 1.2.1) If not I can try to rope in someone else. --- If your project is set up for it, you can reply to this email and have your r

[jira] [Created] (FLINK-6320) Flakey JobManagerHAJobGraphRecoveryITCase

2017-04-18 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-6320: -- Summary: Flakey JobManagerHAJobGraphRecoveryITCase Key: FLINK-6320 URL: https://issues.apache.org/jira/browse/FLINK-6320 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-6293) Flakey JobManagerITCase

2017-04-18 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-6293: --- Labels: test-stability (was: ) > Flakey JobManagerITCase > --- > >

[jira] [Updated] (FLINK-6287) Flakey JobManagerRegistrationTest

2017-04-18 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-6287: --- Labels: test-stability (was: ) > Flakey JobManagerRegistrationTest >

[jira] [Commented] (FLINK-4973) Flakey Yarn tests due to recently added latency marker

2017-04-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972693#comment-15972693 ] Till Rohrmann commented on FLINK-4973: -- I've created FLINK-6319 to track the proper s

[jira] [Created] (FLINK-6319) Add timeout when shutting SystemProcessingTimeService down

2017-04-18 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6319: Summary: Add timeout when shutting SystemProcessingTimeService down Key: FLINK-6319 URL: https://issues.apache.org/jira/browse/FLINK-6319 Project: Flink Issu

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972690#comment-15972690 ] mingleizhang commented on FLINK-6130: - [~Zentol] Doesn't it return the result of the s

[jira] [Commented] (FLINK-6283) Enable to clear a given file cache path

2017-04-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972686#comment-15972686 ] Chesnay Schepler commented on FLINK-6283: - FileCache#copy is a utility method that

[jira] [Commented] (FLINK-6283) Enable to clear a given file cache path

2017-04-18 Thread Zohar Mizrahi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972673#comment-15972673 ] Zohar Mizrahi commented on FLINK-6283: -- Yep, FileCache#copy and therefore, I also add

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972672#comment-15972672 ] Chesnay Schepler commented on FLINK-6130: - [~mingleizhang] The termination future

[jira] [Commented] (FLINK-4973) Flakey Yarn tests due to recently added latency marker

2017-04-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972667#comment-15972667 ] Till Rohrmann commented on FLINK-4973: -- Hi Andrey, thanks for reporting this issue.

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972665#comment-15972665 ] ASF GitHub Bot commented on FLINK-6149: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111953023 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -228,15 +229,24 @@ abstract class BatchTa

[jira] [Commented] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972662#comment-15972662 ] ASF GitHub Bot commented on FLINK-6300: --- Github user NicoK commented on the issue:

[GitHub] flink issue #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3734 +1 (seems to work nicely, as expected) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972654#comment-15972654 ] ASF GitHub Bot commented on FLINK-1984: --- Github user sgran closed the pull request a

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972655#comment-15972655 ] ASF GitHub Bot commented on FLINK-1984: --- GitHub user sgran reopened a pull request:

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972656#comment-15972656 ] mingleizhang commented on FLINK-6130: - [~till.rohrmann] Thanks for review, and except

[GitHub] flink pull request #3586: [FLINK-1984] initial commit of hard constraint eva...

2017-04-18 Thread sgran
Github user sgran closed the pull request at: https://github.com/apache/flink/pull/3586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request #3586: [FLINK-1984] initial commit of hard constraint eva...

2017-04-18 Thread sgran
GitHub user sgran reopened a pull request: https://github.com/apache/flink/pull/3586 [FLINK-1984] initial commit of hard constraint evaluator This is related to the work in FLINK-1984. In earlier patch sets, mesos constraints were evaluated, but that appears to have been dropped in

[jira] [Closed] (FLINK-6286) hbase command not found error

2017-04-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-6286. - Resolution: Fixed Fixed in 3042b182c818a68f93b163fcf02db397580e1782 > hbase command not found error > ---

[jira] [Commented] (FLINK-6286) hbase command not found error

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972651#comment-15972651 ] ASF GitHub Bot commented on FLINK-6286: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3711: [FLINK-6286] [script] Fix the hbase command not fo...

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3711 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink issue #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3734 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[jira] [Updated] (FLINK-6286) hbase command not found error

2017-04-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-6286: -- Fix Version/s: 1.3.0 > hbase command not found error > - > >

[jira] [Commented] (FLINK-2184) Cannot get last element with maxBy/minBy

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972642#comment-15972642 ] ASF GitHub Bot commented on FLINK-2184: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-6291) Internal Timer service cannot be "removed"

2017-04-18 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972650#comment-15972650 ] Gyula Fora commented on FLINK-6291: --- Sounds good :) > Internal Timer service cannot be

[jira] [Commented] (FLINK-6283) Enable to clear a given file cache path

2017-04-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972649#comment-15972649 ] Chesnay Schepler commented on FLINK-6283: - Are you actually using the FileCache fo

[jira] [Comment Edited] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972647#comment-15972647 ] Chesnay Schepler edited comment on FLINK-6130 at 4/18/17 1:18 PM: --

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972647#comment-15972647 ] Chesnay Schepler commented on FLINK-6130: - [~till.rohrmann] Because the resourceMa

[jira] [Commented] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972644#comment-15972644 ] ASF GitHub Bot commented on FLINK-6300: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972631#comment-15972631 ] ASF GitHub Bot commented on FLINK-6300: --- Github user patricklucas commented on the i

[GitHub] flink issue #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread patricklucas
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3734 cc @greghogan, fyi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3110 Thanks @aljoscha, those are my concerns as well. The methods are very prominent in the core APIs and provide only marginal value. It's pretty straightforward to implement the functionality with a `Re

[jira] [Commented] (FLINK-4319) Rework Cluster Management (FLIP-6)

2017-04-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972639#comment-15972639 ] Till Rohrmann commented on FLINK-4319: -- Thanks for sharing [~sedgewickmm18] :-) > Re

<    1   2   3   4   5   >